Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.11.1 #1779

Merged
merged 5 commits into from
Sep 2, 2022
Merged

v1.11.1 #1779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9029673
Pin the Google Maps API version to v3.47. (#1681)
tmeyer2115 Mar 10, 2022
c5edadd
Fix useragent acceptance test (#1623)
cea2aj Nov 29, 2021
a4450c2
gracefully handle analytics error (#1774)
yen-tt Aug 31, 2022
9cab4e8
version bump
Sep 2, 2022
1799128
remove safari browserstack acceptance test temporarily
Sep 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/run_browserstack_acceptance.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ if [[ $GITHUB_REF_NAME == release/*
|| $GITHUB_REF_NAME == master
|| $GITHUB_REF_NAME == support/* ]]
then
npx testcafe "browserstack:ie@11.0,browserstack:safari" --config-file ./.github/testcafe.json -q
# npx testcafe "browserstack:ie@11.0,browserstack:safari" --config-file ./.github/testcafe.json -q
npx testcafe "browserstack:ie@11.0" --config-file ./.github/testcafe.json -q
Copy link
Contributor Author

@yen-tt yen-tt Sep 2, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue with browserstack acceptance test hanging on page load for “Universal search page works as expected” is coming from safari specifically. I tried manually loading up the universal page for that test on safari locally and run through a couple steps, which seems to work fine. Talked to tom, he's okay with ignoring it for now. I removed it from this script so so the deploy actions would pass properly, will add it back after the release.

else
npx testcafe -c 2 "browserstack:ie@11.0" --config-file ./.github/testcafe.json -q
fi
3 changes: 2 additions & 1 deletion .github/testcafe.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"src": ["tests/acceptance/acceptancesuites/*.js", "!tests/acceptance/acceptancesuites/searchbaronlysuite.js"],
"appCommand": "npx serve -l tcp://0.0.0.0:9999",
"appInitDelay": 4000
"appInitDelay": 4000,
"skipJsErrors": true
}
Loading