Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HoursDirectAnswer Field Value Direct Answer. #220

Merged
merged 6 commits into from
Sep 6, 2022
Merged

Conversation

tmeyer2115
Copy link
Contributor

@tmeyer2115 tmeyer2115 commented Sep 6, 2022

This PR adds the new HoursDirectAnswer Field Value Direct Answer. The typing of an Hours Field Value is somewhat complex. All TypeScript types I created for the value were exported. I updated to Direct Answer portion of the test-site as well.

J=SLAP-2359
TEST=auto

@tmeyer2115 tmeyer2115 requested a review from a team as a code owner September 6, 2022 16:54
@coveralls
Copy link

coveralls commented Sep 6, 2022

Pull Request Test Coverage Report for Build 3002032156

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.408%

Totals Coverage Status
Change from base Build 2905732495: 0.0%
Covered Lines: 214
Relevant Lines: 231

💛 - Coveralls

Copy link
Contributor

@oshi97 oshi97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@tmeyer2115 tmeyer2115 changed the title Add HoursDirectAnswer. Add HoursDirectAnswer Field Value Direct Answer. Sep 6, 2022
@tmeyer2115 tmeyer2115 merged commit acfee54 into develop Sep 6, 2022
@tmeyer2115 tmeyer2115 deleted the dev/hours-da branch September 6, 2022 17:08
yen-tt added a commit to yext/search-headless that referenced this pull request Sep 6, 2022
re-export HoursDirectAnswer interfaces from [core pr](yext/search-core#220)
bump alpha version to use in component lib

J=SLAP-2359
@yen-tt yen-tt mentioned this pull request Sep 6, 2022
yen-tt added a commit that referenced this pull request Sep 8, 2022
## Version 2.0.0

### Changes
- `additionalQueryParameter` is now a public field in `SearchConfig` models (#217)

### Breaking Changes
- Updated default and sandbox URL endpoints from `../answers/..` to `../search/..` as part of rebranding process (#196 )
- Restructured StaticFilters models for better developer experience and enforce proper restriction in the kind of combinations of filters supported by the backend
  - Now, static filters can be either a field value filter or a nested object that is composed by combining field value filters. (#201 )
  - `ConjunctionStaticFilter` and `DisjunctionStaticFilter` models were created to reflect such limitation. For example, ANDs of ORs combination is allowed, ORs of ANDs combination is not allowed.  (#204 )
- Updated `FieldValueDirectAnswer` model to properly handle different `value` types. Previously, FieldValueDirectAnswer interface enforces that the `value` field will always be of type `string`. Now, `FieldValueDirectAnswer` is a union type of predefined interfaces with known `value` type and `UnknownFieldValueDirectAnswer` with a generic `value` type for other `fieldType` outside of `BuiltInFieldType`. (#200 #202 )
   - The newly added built-in interfaces can be found in the document page [**here**](https://github.com/yext/search-core/blob/develop/docs/search-core.fieldvaluedirectanswer.md)  (#206 #208 #210 #211 #205 #209 #203 #220 )
- Narrow down `FeaturedSnippetDirectAnswer` TypeScript model to be a union type of   `MultiLineTextSnippetDirectAnswer` and `RichTextSnippetDirectAnswer` as a featured snippet direct answer can only be of fieldType `multi_line_text` or `rich_text`. (#207 #212 )
- All exports marked as `@deprecated` in previous version(s) as part of the rebranding process is now removed in V2 (#216 )
  - For more details, the deprecated identifiers are listed in [v1.8 release notes](https://github.com/yext/search-core/releases/tag/v1.8.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants