docs(MapboxMap): add storybook stories #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J=SLAP-2223 TEST=manual visually reviewed while serving storybook
J=SLAP-2223 TEST=manual serve and view stories
tatimblin
commented
Oct 10, 2022
tatimblin
commented
Oct 10, 2022
|
Current unit coverage is 89.12721893491124% |
nmanu1
reviewed
Oct 11, 2022
J=SLAP-2223 TEST=none
oshi97
reviewed
Oct 11, 2022
nmanu1
reviewed
Oct 11, 2022
yen-tt
reviewed
Oct 11, 2022
J=SLAP-2223 TEST=manual ran storybook and eslint
J=SLAP-2223 TEST=none
nmanu1
reviewed
Oct 12, 2022
oshi97
reviewed
Oct 12, 2022
oshi97
reviewed
Oct 12, 2022
oshi97
reviewed
Oct 12, 2022
oshi97
reviewed
Oct 12, 2022
oshi97
reviewed
Oct 12, 2022
oshi97
reviewed
Oct 12, 2022
oshi97
reviewed
Oct 12, 2022
tmeyer2115
reviewed
Oct 14, 2022
|
Still not able to get the map to render in the percy snapshot even though the testing-library checks pass which check that the map was loaded. Think I'll need some help on this |
oshi97
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
single marker story
multiple marker story
custom marker story - follow docs.mapbox.com guide to add a simple popup pin
J=SLAP-2223
TEST=manual
serve and view stories