Skip to content

Conversation

hstejas
Copy link
Contributor

@hstejas hstejas commented Aug 23, 2025

By initializing start_time_ for server, I hope to measure the time taken to process a request at the end maybe in the set_logger callback and print it.

I only see current usage in client with server retaining the inital min value

By initializing start_time_ for server, I hope to measure the time taken to process a request at the end maybe in the set_logger callback and print it.

I only see current usage in client with server retaining the inital min value
@yhirose
Copy link
Owner

yhirose commented Aug 24, 2025

@hstejas thanks! Could you please add a unit test in test/test.cc?

@hstejas
Copy link
Contributor Author

hstejas commented Aug 24, 2025

@hstejas thanks! Could you please add a unit test in test/test.cc?

Done, I have added a new "/custom" endpoint in the test fixture and member variable to store a callback. I think this will make newer tests easier.
Let me know if this is not okay, i can move the EXPECT_NE to "/hi"

@hstejas hstejas requested a review from yhirose August 25, 2025 15:18
@yhirose
Copy link
Owner

yhirose commented Aug 25, 2025

@hstejas almost! Could you please run clang-format to fix the style-check problem on Github Actions workflow?

@hstejas
Copy link
Contributor Author

hstejas commented Aug 26, 2025

@hstejas almost! Could you please run clang-format to fix the style-check problem on Github Actions workflow?

Done

@yhirose yhirose merged commit b8e21ea into yhirose:master Aug 26, 2025
10 checks passed
@yhirose
Copy link
Owner

yhirose commented Aug 26, 2025

@hstejas thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants