-
-
Notifications
You must be signed in to change notification settings - Fork 878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic test coverage reports with coveralls. #937
Conversation
Thanks! This is very interesting and useful. One question, though: since I do not use testthat (I use my own tiny package testit instead), does covr still work in that case? Or actually, does covr really have to "endorse" a specific testing framework? I have noticed covr a while ago, and I have been waiting for a better documentation (e.g. a package vignette) about how it actually works. Otherwise it is completely magic to me, and I'm not sure if it really works in my case. I tried to read the source code, but it does not seem to be something that I can understand in a few minutes :) |
BTW, while I'm reading the help pages, I have a humble suggestion that you export as fewer functions as possible, e.g. I do not quite see the value of exporting |
install: | ||
- ./travis-tool.sh github_package jimhester/covr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps surprising to you again, I do not use travis-tool.sh, either, since I think it is trivially easy to set it up by myself, and I'm more familiar and comfortable with apt-get
:)
re: exporting functions that is a fair criticism, I un-exported them at r-lib/covr@e77b2a5 , thank you for the suggestion and I agree with your reasoning. I had previously seen that you did not use |
No no I was not criticizing you exporting functions. It was just a suggestion :) Now it seems everything is good. Could you squash your three commits into one? e.g. BTW, I'd still love to see a vignette describing how covr works under the hood. I understand you may not want to spend time on it, but I'm very interested in your magic 👍 |
Ok I squashed everything into one commit! Let me know if there is anything else you need. I think your vignette suggestion is a good one, a couple other people have wanted to know how it works as well. I will put one together soon. |
Automatic test coverage reports with coveralls.
Excellent. Thanks! |
You will have to enable this repo on coveralls at https://coveralls.io/repos/new before merging this pull request for the report to work the first time.