fix(app): Remove all stack configurations. #133
Conversation
WalkthroughRemoves the repository's entire Docker-based runtime and CI infrastructure, updates README/docs to drop Docker/web-server guidance and badges, and applies two small PHP edits: a formatting tweak in a controller and switching SiteController::actions() to a PHP array union. Changes
Sequence Diagram(s)Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #133 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 7 7
===========================================
Files 12 12
Lines 177 172 -5
===========================================
- Hits 177 172 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docs/installation.md (1)
5-7: Make Node.js/npm requirement unambiguous.Per project tooling (foxy runs npm), Node.js and npm are required, not optional. Merge bullets to avoid contradiction and specify a minimal Node.js version.
Suggested wording:
-- [`npm`](https://nodejs.org/en/download/) for frontend dependency management. +- [`Node.js`](https://nodejs.org/en/download/) 18+ (includes `npm`) for frontend dependency management. @@ -### Optional requirements - -- **Node.js**: For advanced asset compilation (optional) +### Optional requirements +<!-- none at the moment -->I can adjust this to match the exact Node.js version you support in CI.
Also applies to: 12-12
🧹 Nitpick comments (7)
docs/installation.md (3)
21-22: Confirm need for --stability=dev in composer create-project.If a stable tag exists, prefer default stability. Otherwise, keep as-is and consider explaining why dev stability is required.
Proposed tweak:
-composer create-project --prefer-dist --stability=dev yii2-extensions/app-basic app-basic +composer create-project --prefer-dist yii2-extensions/app-basic app-basic
29-30: Clarify intent of git-based installs (project bootstrap vs. contributing).Method 3 resets VCS history (rm -rf .git; git init) while Method 2 keeps repo history. If both are meant for new-project bootstraps, mirror the reset step in Method 2 or add a note explaining the difference.
Example note to add after cd app-basic in Method 2: “If starting a new project, run: rm -rf .git && git init”.
Also applies to: 43-44
81-81: Use a consistent placeholder/database name.“app” may confuse readers given the folder is “app-basic”. Consider “app_basic” or explicitly mark it as a placeholder.
-CREATE DATABASE app CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci; +CREATE DATABASE app_basic CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci; +-- or choose your own name and update config/db.php accordinglyREADME.md (2)
16-16: Nit: Align Yii 22 badge text with link/alt.Badge text shows “22” while alt reads “Yii 22.0”. Consider standardizing to “22.0” for consistency.
-<img src="https://img.shields.io/badge/22-0073AA.svg?style=for-the-badge&logo=yii&logoColor=white" alt="Yii 22.0"> +<img src="https://img.shields.io/badge/22.0-0073AA.svg?style=for-the-badge&logo=yii&logoColor=white" alt="Yii 22.0">
140-144: Optional: Pin codecov badge to a branch for deterministic status.If you want the badge to reflect main’s coverage only, append branch=main.
-[](https://codecov.io/github/yii2-extensions/app-basic) +[](https://codecov.io/github/yii2-extensions/app-basic)src/usecase/site/SiteController.php (2)
10-10: Importing a global function is optional here
use function array_merge;isn’t needed; callingarray_merge()resolves to the global function by default. Removing the import reduces noise.-use function array_merge;
21-26: Array merge semantics: current shallow merge with parent precedence
- You’re using
array_merge([...], parent::actions()), which performs a shallow merge and gives parent keys precedence on collisions. With unique top-level action IDs ('404'vs'error'), this is safe today.- If you intend for the child to override parent entries in the future, swap the arguments (Option A).
- To keep parent precedence but avoid a function call, use the array union operator (Option B).
- Trailing commas in function calls are supported (PHP >= 7.3, and your project requires >= 8.1).
Option A (child overrides parent):
- return array_merge( - [ - '404' => ['class' => ErrorAction::class], - ], - parent::actions(), - ); + return array_merge( + parent::actions(), + [ + '404' => ['class' => ErrorAction::class], + ], + );Option B (parent precedence, no function call):
- return array_merge( - [ - '404' => ['class' => ErrorAction::class], - ], - parent::actions(), - ); + return [ + '404' => ['class' => ErrorAction::class], + ] + parent::actions();
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (2)
docker/ssl/localhost-key.pemis excluded by!**/*.pemdocker/ssl/localhost.pemis excluded by!**/*.pem
📒 Files selected for processing (29)
.github/workflows/docker.yml(0 hunks)README.md(3 hunks)docker-compose.caddy.yml(0 hunks)docker-compose.frankenphp.yml(0 hunks)docker-compose.nginx.yml(0 hunks)docker-compose.yml(0 hunks)docker/apache/Dockerfile(0 hunks)docker/apache/apache.conf(0 hunks)docker/apache/vhost.conf(0 hunks)docker/caddy/Caddyfile(0 hunks)docker/caddy/Dockerfile(0 hunks)docker/entrypoint.sh(0 hunks)docker/frankenphp/Caddyfile(0 hunks)docker/frankenphp/Dockerfile(0 hunks)docker/init.sh(0 hunks)docker/nginx/Dockerfile(0 hunks)docker/nginx/default.conf(0 hunks)docker/nginx/nginx.conf(0 hunks)docker/php/php.ini(0 hunks)docker/supervisor/conf.d/apache2.conf(0 hunks)docker/supervisor/conf.d/caddy-php-fpm.conf(0 hunks)docker/supervisor/conf.d/frankenphp.conf(0 hunks)docker/supervisor/conf.d/nginx.conf(0 hunks)docker/supervisor/conf.d/php-fpm.conf(0 hunks)docker/supervisor/conf.d/queue.conf(0 hunks)docker/supervisor/supervisord.conf(0 hunks)docs/installation.md(3 hunks)src/usecase/Controller.php(1 hunks)src/usecase/site/SiteController.php(2 hunks)
💤 Files with no reviewable changes (25)
- docker-compose.caddy.yml
- docker-compose.yml
- docker-compose.frankenphp.yml
- docker/supervisor/conf.d/apache2.conf
- .github/workflows/docker.yml
- docker/apache/vhost.conf
- docker/init.sh
- docker/frankenphp/Dockerfile
- docker/frankenphp/Caddyfile
- docker-compose.nginx.yml
- docker/caddy/Caddyfile
- docker/nginx/nginx.conf
- docker/supervisor/conf.d/nginx.conf
- docker/entrypoint.sh
- docker/supervisor/conf.d/frankenphp.conf
- docker/supervisor/conf.d/queue.conf
- docker/nginx/Dockerfile
- docker/apache/Dockerfile
- docker/caddy/Dockerfile
- docker/supervisor/supervisord.conf
- docker/supervisor/conf.d/php-fpm.conf
- docker/supervisor/conf.d/caddy-php-fpm.conf
- docker/nginx/default.conf
- docker/apache/apache.conf
- docker/php/php.ini
🧰 Additional context used
🧠 Learnings (3)
📚 Learning: 2025-08-25T21:03:02.960Z
Learnt from: terabytesoftw
PR: yii2-extensions/app-basic#128
File: docs/installation.md:7-7
Timestamp: 2025-08-25T21:03:02.960Z
Learning: In yii2-extensions/app-basic project, npm is listed as a system requirement in docs/installation.md because the composer.json file contains scripts that depend on npm commands for frontend asset management and build processes.
Applied to files:
docs/installation.mdREADME.md
📚 Learning: 2025-08-25T21:03:02.960Z
Learnt from: terabytesoftw
PR: yii2-extensions/app-basic#128
File: docs/installation.md:7-7
Timestamp: 2025-08-25T21:03:02.960Z
Learning: The yii2-extensions/app-basic project uses php-forge/foxy Composer plugin which automatically runs npm install during composer install/update, making npm a required system dependency rather than optional. The documentation correctly lists npm in system requirements due to this integration.
Applied to files:
docs/installation.md
📚 Learning: 2025-07-09T14:52:41.210Z
Learnt from: terabytesoftw
PR: yii2-extensions/app-basic#97
File: docs/installation.md:5-8
Timestamp: 2025-07-09T14:52:41.210Z
Learning: The Yii2 framework has multiple active branches including the 2.0.x branch (maintenance/LTS) and the 22.0 branch (development). When specifying version requirements, "2.0.53+ or 22.x" is accurate and should not be changed to only reference the 2.x branch.
Applied to files:
README.md
🪛 LanguageTool
README.md
[grammar] ~141-~141: There might be a mistake here.
Context: ....org/packages/yii2-extensions/app-basic) [
[grammar] ~142-~142: There might be a mistake here.
Context: ...cov.io/github/yii2-extensions/app-basic) [
🔇 Additional comments (4)
README.md (3)
10-10: Badges update looks good.Also applies to: 13-13
19-19: CI badges: good switch to workflow-status shields.Also applies to: 22-23
68-69: Quick start commands are consistent with Installation guide.src/usecase/Controller.php (1)
29-29: LGTM: concise VerbFilter rule; behavior unchangedNo functional change—logout still restricted to POST. Good cleanup.
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docs/installation.md (1)
7-13: Fix npm/Node.js requirement inconsistency.System Requirements list npm as mandatory, but Optional Requirements list Node.js as optional. npm requires Node.js and, per your past context, foxy runs npm during composer install, making Node.js+npm required. Unify under System Requirements and drop the Optional bullet.
- - [`npm`](https://nodejs.org/en/download/) for frontend dependency management. + - [`Node.js`](https://nodejs.org/en/download/) 18+ and `npm` for frontend dependency management. ... -### Optional requirements - -- **Node.js**: For advanced asset compilation (optional) +### Optional requirements +<!-- none at this time -->Context: Using previous learnings that this repo uses php-forge/foxy to invoke npm automatically.
🧹 Nitpick comments (3)
docs/installation.md (2)
54-58: Tighten permissions guidance; avoid implying the web server needs write to tests/_output.Split runtime vs. test output to reduce unnecessary write access for the web user.
-Ensure the following directories are writable by the web server. - -```bash -chmod 775 web/assets runtime tests/_output -``` +Ensure the following directories are writable by the web server (runtime only): +```bash +chmod 775 web/assets runtime +``` +For local testing (CLI user), ensure tests output is writable: +```bash +chmod 775 tests/_output +```
98-107: Optional: specify an LTS baseline for Node.js.Adding an explicit minimum (e.g., Node 18 LTS) reduces “works on my machine” issues for asset builds.
-# Install Node.js dependencies +# Install Node.js dependencies (Node 18+ recommended)README.md (1)
61-61: Cross-link npm requirement to Installation guide.Reduce repetition and keep one source of truth.
->Note: Also, make sure to install [`npm`](https://nodejs.org/en/download/) for frontend dependency management. +>Note: See the Installation Guide for required Node.js/npm versions.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (3)
README.md(4 hunks)docs/installation.md(3 hunks)src/usecase/site/SiteController.php(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- src/usecase/site/SiteController.php
🧰 Additional context used
🧠 Learnings (3)
📚 Learning: 2025-08-25T21:03:02.960Z
Learnt from: terabytesoftw
PR: yii2-extensions/app-basic#128
File: docs/installation.md:7-7
Timestamp: 2025-08-25T21:03:02.960Z
Learning: In yii2-extensions/app-basic project, npm is listed as a system requirement in docs/installation.md because the composer.json file contains scripts that depend on npm commands for frontend asset management and build processes.
Applied to files:
docs/installation.mdREADME.md
📚 Learning: 2025-08-25T21:03:02.960Z
Learnt from: terabytesoftw
PR: yii2-extensions/app-basic#128
File: docs/installation.md:7-7
Timestamp: 2025-08-25T21:03:02.960Z
Learning: The yii2-extensions/app-basic project uses php-forge/foxy Composer plugin which automatically runs npm install during composer install/update, making npm a required system dependency rather than optional. The documentation correctly lists npm in system requirements due to this integration.
Applied to files:
docs/installation.md
📚 Learning: 2025-07-09T14:52:41.210Z
Learnt from: terabytesoftw
PR: yii2-extensions/app-basic#97
File: docs/installation.md:5-8
Timestamp: 2025-07-09T14:52:41.210Z
Learning: The Yii2 framework has multiple active branches including the 2.0.x branch (maintenance/LTS) and the 22.0 branch (development). When specifying version requirements, "2.0.53+ or 22.x" is accurate and should not be changed to only reference the 2.x branch.
Applied to files:
README.md
🪛 LanguageTool
README.md
[grammar] ~141-~141: There might be a mistake here.
Context: ....org/packages/yii2-extensions/app-basic) [
[grammar] ~142-~142: There might be a mistake here.
Context: ...cov.io/github/yii2-extensions/app-basic) [
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: codeception / PHP 8.2-windows-2022
🔇 Additional comments (5)
docs/installation.md (2)
21-22: Consistent rename to app-basic looks good.Composer, Git clone, and cd paths are aligned across all methods.
Also applies to: 29-30, 43-44
81-82: DB name change ripple effects verified
Search across code, config, CI, fixtures, and .env found no occurrences ofmyappor mismatchedapp_basic; no updates required.README.md (3)
10-17: Badges updated to match supported stacks and workflows.PHP/Yii and CI badges align with current support; removal of Docker-related badges is consistent with the PR goal.
Also applies to: 19-23
68-69: No stable release available – retain--stability=devinstall. Packagist lists only dev branches (dev-main, dev-fix-mini-39, etc.) foryii2-extensions/app-basic, so a default stable install isn’t possible.
1-168: No stale Docker references or broken relative links found
All Markdown links in README.md correctly resolve to files under docs/, and no Docker artifacts remain.
…shots documentation.
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (1)
README.md (1)
19-23: Badges point to build/static workflows; verify PHPUnit + Codecov are still run.After removing stack configs, confirm build.yml runs phpunit with coverage and uploads to Codecov; static.yml runs PHPStan. Mirrors an earlier note—linking for continuity.
#!/bin/bash fd build.yml .github/workflows && fd static.yml .github/workflows rg -nP '(phpunit|vendor/bin/phpunit)' .github/workflows -C2 rg -nP 'codecov' .github/workflows -C2 rg -nP '(phpstan|vendor/bin/phpstan)' .github/workflows -C2
🧹 Nitpick comments (4)
README.md (4)
13-17: Version badges: keep both branches; tweak labels to avoid staleness.Good call showing both 2.0.x (LTS) and 22.x per project guidance. Consider making alt text version-agnostic so it won’t look stale on future bumps.
Apply:
- <img src="https://img.shields.io/badge/2.0.53-0073AA.svg?style=for-the-badge&logo=yii&logoColor=white" alt="Yii 2.0.53"> + <img src="https://img.shields.io/badge/2.0.x-0073AA.svg?style=for-the-badge&logo=yii&logoColor=white" alt="Yii 2.0.x"> ... - <img src="https://img.shields.io/badge/22.0-0073AA.svg?style=for-the-badge&logo=yii&logoColor=white" alt="Yii 22.0"> + <img src="https://img.shields.io/badge/22.x-0073AA.svg?style=for-the-badge&logo=yii&logoColor=white" alt="Yii 22.x">
68-70: Quick start uses --stability=dev; consider stable path.If a stable tag exists, prefer the stable install; otherwise keep dev.
Provide both:
-composer create-project --prefer-dist --stability=dev yii2-extensions/app-basic app-basic +## Stable (preferred) +composer create-project --prefer-dist yii2-extensions/app-basic app-basic +## Dev (if you need the latest) +# composer create-project --prefer-dist --stability=dev yii2-extensions/app-basic app-basic
140-144: Badge alt text polish (accessibility/consistency).Capitalize names and clarify labels.
-[](https://codecov.io/github/yii2-extensions/app-basic) -[](https://github.com/yii2-extensions/app-basic/actions/workflows/static.yml) +[](https://codecov.io/github/yii2-extensions/app-basic) +[](https://github.com/yii2-extensions/app-basic/actions/workflows/static.yml)
157-157: X profile badge: clarify label text.Minor wording tweak for readability.
-[](https://x.com/Terabytesoftw) +[](https://x.com/Terabytesoftw)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
README.md(5 hunks)docs/screenshots.md(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- docs/screenshots.md
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-07-09T14:52:41.210Z
Learnt from: terabytesoftw
PR: yii2-extensions/app-basic#97
File: docs/installation.md:5-8
Timestamp: 2025-07-09T14:52:41.210Z
Learning: The Yii2 framework has multiple active branches including the 2.0.x branch (maintenance/LTS) and the 22.0 branch (development). When specifying version requirements, "2.0.53+ or 22.x" is accurate and should not be changed to only reference the 2.x branch.
Applied to files:
README.md
📚 Learning: 2025-08-25T21:03:02.960Z
Learnt from: terabytesoftw
PR: yii2-extensions/app-basic#128
File: docs/installation.md:7-7
Timestamp: 2025-08-25T21:03:02.960Z
Learning: In yii2-extensions/app-basic project, npm is listed as a system requirement in docs/installation.md because the composer.json file contains scripts that depend on npm commands for frontend asset management and build processes.
Applied to files:
README.md
🪛 LanguageTool
README.md
[grammar] ~141-~141: There might be a mistake here.
Context: ....org/packages/yii2-extensions/app-basic) [
[grammar] ~142-~142: There might be a mistake here.
Context: ...cov.io/github/yii2-extensions/app-basic) [
[grammar] ~153-~153: There might be a mistake here.
Context: ...uide](docs/testing.md) - 📸 Screenshots ## Our social networks [
🔇 Additional comments (4)
README.md (4)
10-10: composer.json PHP version constraint matches README badge
composer.json requires “php”: “>=8.1”, which aligns with the README badge.
117-117: No changes needed: README sample aligns with source (SiteController is declared final).
153-153: No broken links in screenshots doc or image references
docs/screenshots.md is present and README’s image references (docs/images/home-dark.png, docs/images/home.png) exist in docs/images.
161-161: No action needed – LICENSE.md exists, so the badge link is valid.
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (2)
README.md (2)
19-23: Badges depend on CI steps—avoid drift.These PHPUnit/PHPStan badges assume build.yml runs phpunit (with coverage) and static.yml runs phpstan. Align workflows accordingly.
142-142: Codecov badge requires upload in CI.Ensure coverage is generated (phpunit --coverage-xml) and uploaded via codecov action so this badge updates.
🧹 Nitpick comments (2)
README.md (2)
68-69: Prefer stable install command for newcomers.Consider showing a stable default and keep the dev variant as an alternative.
-composer create-project --prefer-dist --stability=dev yii2-extensions/app-basic app-basic +composer create-project --prefer-dist yii2-extensions/app-basic app-basic +# If you need the latest dev: +# composer create-project --prefer-dist --stability=dev yii2-extensions/app-basic app-basic
117-117: Final controller in docs—confirm intent.Marking the example controller final prevents extension; if that’s not the lesson you want to convey, drop final.
-final class SiteController extends Controller +class SiteController extends Controller
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (4)
docs/images/404-dark.pngis excluded by!**/*.pngdocs/images/404.pngis excluded by!**/*.pngdocs/images/home-dark.pngis excluded by!**/*.pngdocs/images/home.pngis excluded by!**/*.png
📒 Files selected for processing (1)
README.md(5 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-07-09T14:52:41.210Z
Learnt from: terabytesoftw
PR: yii2-extensions/app-basic#97
File: docs/installation.md:5-8
Timestamp: 2025-07-09T14:52:41.210Z
Learning: The Yii2 framework has multiple active branches including the 2.0.x branch (maintenance/LTS) and the 22.0 branch (development). When specifying version requirements, "2.0.53+ or 22.x" is accurate and should not be changed to only reference the 2.x branch.
Applied to files:
README.md
📚 Learning: 2025-08-25T21:03:02.960Z
Learnt from: terabytesoftw
PR: yii2-extensions/app-basic#128
File: docs/installation.md:7-7
Timestamp: 2025-08-25T21:03:02.960Z
Learning: In yii2-extensions/app-basic project, npm is listed as a system requirement in docs/installation.md because the composer.json file contains scripts that depend on npm commands for frontend asset management and build processes.
Applied to files:
README.md
🪛 LanguageTool
README.md
[grammar] ~141-~141: There might be a mistake here.
Context: ....org/packages/yii2-extensions/app-basic) [
[grammar] ~142-~142: There might be a mistake here.
Context: ...cov.io/github/yii2-extensions/app-basic) [
[grammar] ~153-~153: There might be a mistake here.
Context: ...uide](docs/testing.md) - 📸 Screenshots ## Our social networks [
🔇 Additional comments (6)
README.md (6)
13-17: Yii branch badges: good and consistent with supported branches.Keeping both 2.0.x and 22.0.x aligns with prior guidance for this project.
140-141: Packagist and StyleCI badges look good.Also applies to: 144-144
157-157: Social badge/link OK.
10-10: Verified PHP badge: composer.json requires PHP >= 8.1, matching the badge.
161-161: License badge link is valid
LICENSE.md is present in the repository and the badge’s target file exists.
153-153: Verified screenshot documentation and assets are present.
1 participant
Summary by CodeRabbit