fix(config): Update Caddy configuration and replace CaddyfileCli with Caddyfile for improved SSL setup.
#166
Conversation
…with `Caddyfile` for improved SSL setup.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughSwitches server configuration from CaddyfileCli to Caddyfile, enables HTTPS on port 8443 with local TLS certs, updates FrankenPHP worker path and document root to Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant U as User Browser
participant C as Caddy (HTTPS :8443)
participant F as FrankenPHP Worker
participant A as App (./web/index.php)
U->>C: HTTPS request to https://localhost:8443/...
Note over C: TLS handshake using ./web/ssl cert/key
C->>F: Forward PHP request (document root ./web)
F->>A: Execute ./web/index.php
A-->>F: App response
F-->>C: Response to Caddy
C-->>U: HTTPS response
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
…le` and adjust Docker run commands for improved server configuration.
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
…ds in `README.md`.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
🧹 Nitpick comments (2)
.github/workflows/build.yml (1)
31-31: Pin remote install script or verify checksum.Piping an unpinned remote script to
shis a supply-chain risk. Pin a version or verify SHA256.Caddyfile (1)
18-18: Restore env override for document root.Retain flexibility by honoring SERVER_ROOT with a sensible default.
- root ./web + root {$SERVER_ROOT:./web}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (2)
web/ssl/localhost-key.pemis excluded by!**/*.pemweb/ssl/localhost.pemis excluded by!**/*.pem
📒 Files selected for processing (5)
.github/workflows/build.yml(1 hunks)Caddyfile(1 hunks)CaddyfileCli(0 hunks)README.md(1 hunks)tests/Acceptance.suite.yml(1 hunks)
💤 Files with no reviewable changes (1)
- CaddyfileCli
🔇 Additional comments (5)
tests/Acceptance.suite.yml (1)
10-10: Disable SSL verification for self-signed certs in PhpBrowser config
Self-signed TLS will fail Guzzle’s default validation (app.studyraid.com). In yourtests/Acceptance.suite.yml, undermodules.config.PhpBrowser, add:modules: config: PhpBrowser: url: https://localhost:8443/ verify: falseIf
verifyisn’t supported by your Codeception version, instead disable via curl options:curl: CURLOPT_SSL_VERIFYPEER: false CURLOPT_SSL_VERIFYHOST: falseConfirm which option your Codeception version accepts.
Caddyfile (2)
4-4: HTTPS port set to 8443; update UDP mapping for HTTP/3.Since TLS listens on 8443, QUIC should also expose 8443/udp (not 443/udp). README examples should match.
7-7: Verify worker path exists.Confirm
./web/index.phpis present in the repo/CI image; otherwise PHP routing will 404.README.md (2)
82-82: Good switch to unified Caddyfile.
102-103: Helpful path note.
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (2)
README.md (2)
90-97: Windows/Gitbash Docker mapping and TLS envs look correct.
TCP+UDP exposed on 8443 match https_port; envs align with TLS on localhost.
120-120: Protocol corrected to HTTPS — thanks for fixing.
Matches TLS on 8443.
🧹 Nitpick comments (1)
README.md (1)
108-115: Fix trailing spaces after backslash (Linux/WSL snippet).
The extra spaces after the backslash on Line 115 can break line continuation when copy-pasted.Apply:
- -p 8443:8443/udp \ + -p 8443:8443/udp \
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
README.md(1 hunks)
🔇 Additional comments (2)
README.md (2)
82-82: CLI now uses Caddyfile — good switch.
./frankenphp run --config ./Caddyfile --watchaligns with the new config approach.
102-102: Note update is fine.
No action needed.
1 participant
Summary by CodeRabbit