Skip to content

Conversation

terabytesoftw
Copy link
Member

@terabytesoftw terabytesoftw commented Oct 9, 2025

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

Summary by CodeRabbit

  • New Features
    • Introduced Apache-based Docker stack with HTTPS support, healthcheck, and persistent caches/volumes.
    • Simplified startup via docker compose; access app at https://localhost:8443.
  • Documentation
    • Updated README: new quick start, HTTPS URL, revised badges/links; removed traditional deployment section.
    • Added changelog entries for enhancements and fixes.
  • Tests
    • Switched acceptance tests to target HTTPS.
  • Chores
    • Reworked CI to explicit Docker steps for build and tests.
    • Added secret scanning configuration.
    • Updated development dependencies.

@terabytesoftw terabytesoftw added the bug Something isn't working label Oct 9, 2025
Copy link

coderabbitai bot commented Oct 9, 2025

Caution

Review failed

Failed to post review comments

Walkthrough

Adds GitLeaks allowlist, replaces CI Codeception action with Docker-based Apache job, introduces Docker Compose Apache service with SSL and healthcheck, updates tests to HTTPS, removes Codeception env configs, adjusts acceptance suite URL, updates README badges/instructions for Apache workflow, extends changelog, and adds a dev dependency.

Changes

Cohort / File(s) Summary of changes
CI workflow (Apache + Docker)
.github/workflows/build.yml
Replaces reusable Codeception action with explicit steps: checkout, docker compose up/build/wait, run codecept build and tests inside container. Removes secrets and previous action configs.
Docker stack (Apache service)
docker-compose.yml
Adds app-basic service using GHCR Apache image, SSL cert mounts, env vars, healthcheck, ports 8080/8443, restart policy, code and cache volumes.
Tests and Codeception configs
codeception.yml, tests/Acceptance.suite.yml, tests/_envs/*
Removes paths.envs and environment-specific files (dockerized.yml, php-builtin.yml). Updates Acceptance PhpBrowser URL to https://localhost:443/.
Security linting
.github/linters/.gitleaks.toml
Adds GitLeaks config with allowlist for web/ssl/.*.
Documentation
README.md, CHANGELOG.md
README: switches badges/links to Apache branch, replaces install/start with Docker Compose, updates URLs to HTTPS, removes traditional deployment section. CHANGELOG: adds entries for Apache stack, workflow and Docker updates, badges.
Dependencies
composer.json
Adds dev requirement: voku/portable-utf8 (dev-master as 6.0.13).

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor Dev as GitHub Actions Runner
  participant DC as Docker Engine
  participant App as app-basic Container
  participant T as Codeception

  Dev->>DC: docker compose up -d --build --wait
  DC-->>Dev: Services started
  Dev->>App: docker exec codecept build
  App-->>Dev: Modules generated
  Dev->>App: docker exec codecept run
  App->>T: Execute tests
  T-->>App: Results
  App-->>Dev: Test report
Loading
sequenceDiagram
  autonumber
  participant U as User
  participant Host as Localhost (8080/8443)
  participant App as app-basic (Apache+PHP-FPM)
  participant HC as Healthcheck

  HC->>App: GET /health (curl)
  App-->>HC: 200 OK when ready

  U->>Host: https://localhost:8443/
  Host->>App: Forward HTTPS traffic
  App-->>U: Serve application response
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Poem

In a dock by the bay, my containers hum,
Apache lights lanterns—443 has come.
Tests tiptoe inside, codecept drums a beat,
Badges wink green, all tidy and neat.
I twitch my ears—healthcheck says “OK!” 🐇✨

Pre-merge checks and finishing touches and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title Check ❓ Inconclusive The title “Sync to main branch” does not describe the substantive changes introduced in this pull request and instead refers only to the merge action, making it too generic to convey the primary updates to workflows, configuration, and documentation. Please revise the pull request title to a concise description of the main changes, such as summarizing the new Apache CI workflow, updated Docker setup, and configuration adjustments, so that reviewers can quickly understand the purpose of the changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch sync-to-main-19
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch sync-to-main-19

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@terabytesoftw terabytesoftw changed the base branch from main to apache October 9, 2025 10:01
@terabytesoftw terabytesoftw merged commit d8790ea into apache Oct 9, 2025
31 checks passed
@terabytesoftw terabytesoftw deleted the sync-to-main-19 branch October 9, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant