refactor: Test assertions in NestedSetsQueryBehaviorTest class for consistency.
#43
Conversation
WalkthroughThe changes update assertion message strings in two test files by converting single-quoted strings (with escaped single quotes) to double-quoted strings (with unescaped single quotes). No test logic, control flow, or functionality is altered; only the formatting of assertion messages is affected for consistency. Changes
Possibly related PRs
Suggested labels
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 phpcs (3.7.2)tests/NestedSetsBehaviorTest.phpWarning: PHP Startup: Invalid date.timezone value 'UTC', using 'UTC' instead in Unknown on line 0 Fatal error: Uncaught Error: Class "Phar" not found in /usr/local/bin/phpcs:3 tests/NestedSetsQueryBehaviorTest.phpWarning: PHP Startup: Invalid date.timezone value 'UTC', using 'UTC' instead in Unknown on line 0 Fatal error: Uncaught Error: Class "Phar" not found in /usr/local/bin/phpcs:3 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🧰 Additional context used🧠 Learnings (1)📓 Common learnings🪛 PHPMD (2.15.0)tests/NestedSetsQueryBehaviorTest.php25-25: Avoid using static access to class '\yii\helpers\ArrayHelper' in method 'testReturnLeavesForSingleAndMultipleTreeModels'. (Clean Code Rules) (StaticAccess) 41-41: Avoid using static access to class '\yii\helpers\ArrayHelper' in method 'testReturnRootsForSingleAndMultipleTreeModels'. (Clean Code Rules) (StaticAccess) tests/NestedSetsBehaviorTest.php345-345: Avoid using static access to class '\yii2\extensions\nestedsets\tests\support\model\MultipleTree' in method 'testReturnTrueAndMatchXmlAfterPrependToUpForTreeAndMultipleTree'. (Clean Code Rules) (StaticAccess) 398-398: Avoid using static access to class '\yii2\extensions\nestedsets\tests\support\model\MultipleTree' in method 'testReturnTrueAndMatchXmlAfterPrependToDownForTreeAndMultipleTree'. (Clean Code Rules) (StaticAccess) 496-496: Avoid using static access to class '\yii2\extensions\nestedsets\tests\support\model\Tree' in method 'testThrowExceptionWhenPrependToTargetIsChild'. (Clean Code Rules) (StaticAccess) 530-530: Avoid using static access to class '\yii2\extensions\nestedsets\tests\support\model\MultipleTree' in method 'testReturnTrueAndMatchXmlAfterAppendToUpForTreeAndMultipleTree'. (Clean Code Rules) (StaticAccess) 583-583: Avoid using static access to class '\yii2\extensions\nestedsets\tests\support\model\MultipleTree' in method 'testReturnTrueAndMatchXmlAfterAppendToDownForTreeAndMultipleTree'. (Clean Code Rules) (StaticAccess) 667-667: Avoid using static access to class '\yii2\extensions\nestedsets\tests\support\model\Tree' in method 'testThrowExceptionWhenAppendToTargetIsSame'. (Clean Code Rules) (StaticAccess) 688-688: Avoid using static access to class '\yii2\extensions\nestedsets\tests\support\model\Tree' in method 'testThrowExceptionWhenAppendToTargetIsChild'. (Clean Code Rules) (StaticAccess) 725-725: Avoid using static access to class '\yii2\extensions\nestedsets\tests\support\model\MultipleTree' in method 'testReturnTrueAndMatchXmlAfterInsertBeforeUpForTreeAndMultipleTree'. (Clean Code Rules) (StaticAccess) 778-778: Avoid using static access to class '\yii2\extensions\nestedsets\tests\support\model\MultipleTree' in method 'testReturnTrueAndMatchXmlAfterInsertBeforeDownForTreeAndMultipleTree'. (Clean Code Rules) (StaticAccess) 879-879: Avoid using static access to class '\yii2\extensions\nestedsets\tests\support\model\Tree' in method 'testThrowExceptionWhenInsertBeforeTargetIsChild'. (Clean Code Rules) (StaticAccess) 900-900: Avoid using static access to class '\yii2\extensions\nestedsets\tests\support\model\Tree' in method 'testThrowExceptionWhenInsertBeforeTargetIsRoot'. (Clean Code Rules) (StaticAccess) 934-934: Avoid using static access to class '\yii2\extensions\nestedsets\tests\support\model\MultipleTree' in method 'testReturnTrueAndMatchXmlAfterInsertAfterUpForTreeAndMultipleTree'. (Clean Code Rules) (StaticAccess) 987-987: Avoid using static access to class '\yii2\extensions\nestedsets\tests\support\model\MultipleTree' in method 'testReturnTrueAndMatchXmlAfterInsertAfterDownForTreeAndMultipleTree'. (Clean Code Rules) (StaticAccess) 1085-1085: Avoid using static access to class '\yii2\extensions\nestedsets\tests\support\model\Tree' in method 'testThrowExceptionWhenInsertAfterTargetIsChild'. (Clean Code Rules) (StaticAccess) 1103-1103: Avoid using static access to class '\yii2\extensions\nestedsets\tests\support\model\Tree' in method 'testThrowExceptionWhenInsertAfterTargetIsRoot'. (Clean Code Rules) (StaticAccess) 1261-1261: Avoid using static access to class '\yii\helpers\ArrayHelper' in method 'testReturnParentsForTreeAndMultipleTreeWithAndWithoutDepth'. (Clean Code Rules) (StaticAccess) 1266-1266: Avoid using static access to class '\yii\helpers\ArrayHelper' in method 'testReturnParentsForTreeAndMultipleTreeWithAndWithoutDepth'. (Clean Code Rules) (StaticAccess) 1271-1271: Avoid using static access to class '\yii\helpers\ArrayHelper' in method 'testReturnParentsForTreeAndMultipleTreeWithAndWithoutDepth'. (Clean Code Rules) (StaticAccess) 1287-1287: Avoid using static access to class '\yii\helpers\ArrayHelper' in method 'testReturnChildrenForTreeAndMultipleTreeWithAndWithoutDepth'. (Clean Code Rules) (StaticAccess) 1292-1292: Avoid using static access to class '\yii\helpers\ArrayHelper' in method 'testReturnChildrenForTreeAndMultipleTreeWithAndWithoutDepth'. (Clean Code Rules) (StaticAccess) 1297-1297: Avoid using static access to class '\yii\helpers\ArrayHelper' in method 'testReturnChildrenForTreeAndMultipleTreeWithAndWithoutDepth'. (Clean Code Rules) (StaticAccess) 1313-1313: Avoid using static access to class '\yii\helpers\ArrayHelper' in method 'testReturnLeavesForTreeAndMultipleTree'. (Clean Code Rules) (StaticAccess) 1329-1329: Avoid using static access to class '\yii\helpers\ArrayHelper' in method 'testReturnPrevNodesForTreeAndMultipleTree'. (Clean Code Rules) (StaticAccess) 1345-1345: Avoid using static access to class '\yii\helpers\ArrayHelper' in method 'testReturnNextNodesForTreeAndMultipleTree'. (Clean Code Rules) (StaticAccess) 1369-1369: Avoid using static access to class '\yii2\extensions\nestedsets\tests\support\model\MultipleTree' in method 'testReturnIsChildOfForMultipleTreeNodeUnderVariousAncestors'. (Clean Code Rules) (StaticAccess) 1377-1377: Avoid using static access to class '\yii2\extensions\nestedsets\tests\support\model\MultipleTree' in method 'testReturnIsChildOfForMultipleTreeNodeUnderVariousAncestors'. (Clean Code Rules) (StaticAccess) 1385-1385: Avoid using static access to class '\yii2\extensions\nestedsets\tests\support\model\MultipleTree' in method 'testReturnIsChildOfForMultipleTreeNodeUnderVariousAncestors'. (Clean Code Rules) (StaticAccess) 1393-1393: Avoid using static access to class '\yii2\extensions\nestedsets\tests\support\model\MultipleTree' in method 'testReturnIsChildOfForMultipleTreeNodeUnderVariousAncestors'. (Clean Code Rules) (StaticAccess) 1496-1496: Avoid using static access to class '\yii2\extensions\nestedsets\tests\support\model\Tree' in method 'testReturnAffectedRowsAndUpdateTreeAfterDeleteWithChildrenWhenManualTransactionIsUsed'. (Clean Code Rules) (StaticAccess) 1500-1500: Avoid using static access to class '\yii2\extensions\nestedsets\tests\support\model\Tree' in method 'testReturnAffectedRowsAndUpdateTreeAfterDeleteWithChildrenWhenManualTransactionIsUsed'. (Clean Code Rules) (StaticAccess) 1504-1504: Avoid using static access to class '\yii2\extensions\nestedsets\tests\support\model\Tree' in method 'testReturnAffectedRowsAndUpdateTreeAfterDeleteWithChildrenWhenManualTransactionIsUsed'. (Clean Code Rules) (StaticAccess) 1947-1947: Avoid using static access to class '\yii2\extensions\nestedsets\tests\support\model\TreeWithStrictValidation' in method 'testMakeRootWithRunValidationParameterUsingStrictValidation'. (Clean Code Rules) (StaticAccess) ⏰ Context from checks skipped due to timeout of 90000ms (6)
🔇 Additional comments (2)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #43 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 91 91
===========================================
Files 2 2
Lines 474 474
===========================================
Hits 474 474 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 participant
Summary by CodeRabbit