Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add working with closures to ArrayHelper::map() #79

Merged
merged 4 commits into from Dec 24, 2020
Merged

Add working with closures to ArrayHelper::map() #79

merged 4 commits into from Dec 24, 2020

Conversation

Spell6inder
Copy link
Contributor

if $group=null and $from or $to is Closure then array_column throw errors

Q A
Is bugfix? ✔️
New feature? ❌
Breaks BC? ❌
Fixed issues -

@Spell6inder
Copy link
Contributor Author

Later I will try to find time to add tests and correct the style

@vjik vjik added the status:under development Someone is working on a pull request. label Dec 24, 2020
@Spell6inder
Copy link
Contributor Author

I add tests and correct the style

@samdark samdark added status:code review The pull request needs review. and removed status:under development Someone is working on a pull request. labels Dec 24, 2020
@samdark samdark requested a review from vjik December 24, 2020 16:44
@samdark samdark merged commit 36b86a2 into yiisoft:master Dec 24, 2020
@samdark
Copy link
Member

samdark commented Dec 24, 2020

Thanks!

@Spell6inder Spell6inder deleted the patch-1 branch December 25, 2020 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark approved these changes

@vjik vjik vjik approved these changes

Assignees
No one assigned
Labels
status:code review The pull request needs review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Spell6inder @samdark @vjik