Skip to content

Refactoring using TTL + Remove encode column names in queries + Add PDO extension to composer.json #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 12, 2021
Merged

Refactoring using TTL + Remove encode column names in queries + Add PDO extension to composer.json #7

merged 5 commits into from
Oct 12, 2021

Conversation

vjik
Copy link
Member

@vjik vjik commented Oct 11, 2021 •
edited
Loading

Q A
Is bugfix? ❌
New feature? ❌
Breaks BC? ✔️
Fixed issues #5

@vjik vjik changed the title Refactoring using TTL Refactoring using TTL + Remove encode column names in queries + Add PDO extension to composer.json Oct 11, 2021
@vjik vjik added the status:code review The pull request needs review. label Oct 11, 2021
@vjik vjik requested a review from a team October 11, 2021 18:47
@terabytesoftw
Copy link
Member

For now it is good not to remove the encoding of the columns, until you have the tests for all the drivers.

@vjik
Copy link
Member Author

vjik commented Oct 11, 2021

For now it is good not to remove the encoding of the columns, until you have the tests for all the drivers.

You want add tests for all providers in this package?

darkdef
darkdef reviewed Oct 11, 2021
View reviewed changes
@terabytesoftw terabytesoftw linked an issue Oct 12, 2021 that may be closed by this pull request
Wrong ttl after normalizeTtl #5
Closed
@terabytesoftw terabytesoftw merged commit 9b68843 into master Oct 12, 2021
@terabytesoftw terabytesoftw deleted the confused-refactoring branch October 12, 2021 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darkdef darkdef darkdef left review comments

+1 more reviewer

@devanych devanych devanych approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
status:code review The pull request needs review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong ttl after normalizeTtl
4 participants
@vjik @terabytesoftw @darkdef @devanych