Skip to content

Raise psr/simple-cache to ^2.0|^3.0 and PHP to ^8.0 #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2022
Merged

Raise psr/simple-cache to ^2.0|^3.0 and PHP to ^8.0 #44

merged 1 commit into from
Jul 21, 2022

Conversation

dehbka
Copy link
Contributor

@dehbka dehbka commented Jul 9, 2022 •
edited
Loading

Q A
Is bugfix? ❌
New feature? ❌
Breaks BC? ✔️
Fixed issues 43

rustamwin
rustamwin reviewed Jul 9, 2022
View reviewed changes
Copy link
Member

@rustamwin rustamwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version 7.4 needs to be removed from GitHub workflows. And of course need changelog line.

@rustamwin rustamwin requested a review from a team July 9, 2022 19:04
@rustamwin rustamwin added the status:under development Someone is working on a pull request. label Jul 9, 2022
@rustamwin rustamwin linked an issue Jul 9, 2022 that may be closed by this pull request
Raise psr/simple-cache to ^2.0|^3.0 and PHP to ^8.0 #43
Closed
@dehbka dehbka requested a review from rustamwin July 9, 2022 22:06
rustamwin
rustamwin requested changes Jul 10, 2022
View reviewed changes
@rustamwin rustamwin added status:code review The pull request needs review. and removed status:under development Someone is working on a pull request. labels Jul 10, 2022
rustamwin
rustamwin reviewed Jul 10, 2022
View reviewed changes
Copy link
Member

@rustamwin rustamwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lines should be removed.

vjik
vjik requested changes Jul 12, 2022
View reviewed changes
@dehbka dehbka requested a review from vjik July 12, 2022 19:32
vjik
vjik requested changes Jul 14, 2022
View reviewed changes
@dehbka dehbka requested review from vjik and rustamwin July 16, 2022 17:15
@samdark samdark merged commit 72224f8 into yiisoft:master Jul 21, 2022
@samdark
Copy link
Member

samdark commented Jul 21, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vjik vjik vjik approved these changes

@rustamwin rustamwin Awaiting requested review from rustamwin

Assignees
No one assigned
Labels
status:code review The pull request needs review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Raise psr/simple-cache to ^2.0|^3.0 and PHP to ^8.0
4 participants
@dehbka @samdark @vjik @rustamwin