Don't create cache directory in constructor + Fix nested directory permissions #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vjik
commented
Jan 10, 2025
vjik
commented
| Q | A |
|---|---|
| Is bugfix? | ✔️ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #88 +/- ##
============================================
+ Coverage 91.13% 91.19% +0.05%
+ Complexity 72 69 -3
============================================
Files 1 1
Lines 158 159 +1
============================================
+ Hits 144 145 +1
Misses 14 14 ☔ View full report in Codecov by Sentry. |
samdark
reviewed
Jan 10, 2025
| } | ||
|
|
||
| $result = !is_file($path) && mkdir(directory: $path, recursive: true) && is_dir($path); | ||
| mkdir($path, recursive: true); |
There was a problem hiding this comment.
Wouldn't it fail in case of race condition? is_dir + mkdir is not an atomic operation.
There was a problem hiding this comment.
It will. Race condition don't fixed in this PR. I make it next PR.
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
samdark
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.