Skip to content

Conversation

darkdef
Copy link
Contributor

@darkdef darkdef commented Nov 14, 2022

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

@what-the-diff
Copy link

what-the-diff bot commented Nov 14, 2022

  • The method resetSequence() in DMLQueryBuilder.php was changed to return a string instead of an array
  • In CommandTest, the testExecuteResetSequence() function was added which tests that after deleting and then reseeding the sequence for table item, it will start at 1 again (instead of 2)
  • In QueryBuilderTest, we change what is expected from $qb->resetSequence('item') so that it returns "DBCC CHECKIDENT ('[item]', RESEED)" instead of "DBCC CHECKIDENT ('[item]', RESEED, 0) WITH NO_INFOMSGS;DBCC CHECKIDENT ('[item]', RESEED)"

@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Base: 94.51% // Head: 94.49% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (9655e57) compared to base (6845480).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #129      +/-   ##
============================================
- Coverage     94.51%   94.49%   -0.03%     
  Complexity      209      209              
============================================
  Files            16       16              
  Lines           529      527       -2     
============================================
- Hits            500      498       -2     
  Misses           29       29              
Impacted Files Coverage Δ
src/DMLQueryBuilder.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@darkdef darkdef merged commit a489e01 into yiisoft:master Nov 14, 2022
@darkdef darkdef deleted the reset_sequence_fix branch November 14, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants