Skip to content

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

@what-the-diff
Copy link

what-the-diff bot commented Dec 6, 2022

  • Removed the BaseCommandProvider class and extended AbstractCommandProvider.
  • Added parent::batchInsert() to batchInsert method instead of calling it from BaseCommandProvider instance.
  • Deleted rawSql, update and upsert methods as they are already implemented in AbstractCommandProvider class now (and we don't need them anymore).

@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Base: 94.93% // Head: 94.93% // No change to project coverage 👍

Coverage data is based on head (56bb9ec) compared to base (561b9a9).
Patch has no changes to coverable lines.

❗ Current head 56bb9ec differs from pull request most recent head 8a40851. Consider uploading reports for the commit 8a40851 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #150   +/-   ##
=========================================
  Coverage     94.93%   94.93%           
  Complexity      326      326           
=========================================
  Files            16       16           
  Lines           809      809           
=========================================
  Hits            768      768           
  Misses           41       41           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@terabytesoftw terabytesoftw merged commit 6bd568c into master Dec 7, 2022
@terabytesoftw terabytesoftw deleted the simplify-command-provider branch December 7, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant