Skip to content

Fix for upsert behavior #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 28, 2022
Merged

Fix for upsert behavior #165

merged 3 commits into from
Dec 28, 2022

Conversation

darkdef
Copy link
Contributor

@darkdef darkdef commented Dec 27, 2022

Q A
Is bugfix? ✔️
New feature? ❌
Breaks BC? ❌

@what-the-diff
Copy link

what-the-diff bot commented Dec 27, 2022

  • Fix bug with empty update part in upsert query.
  • Add test for case when no unique columns in table - simple insert should be used instead of upsert (upsert is not supported by sqlite).

@darkdef darkdef merged commit 869ff84 into yiisoft:master Dec 28, 2022
@darkdef darkdef deleted the upsert_fix2 branch December 28, 2022 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terabytesoftw terabytesoftw terabytesoftw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darkdef @terabytesoftw