Skip to content

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

@what-the-diff
Copy link

what-the-diff bot commented Dec 28, 2022

  • composer.json:
    • change the version of yiisoft/db from ^3.0@dev to dev-add-more-tests as 3.0@dev
  • tests/QueryTest.php:
    • extend CommonQueryTest instead of AbstractQueryTest, because it was moved there in a previous commit (yiisoft/yii2-framework@b8f9d7c) and we need this class for testing purposes here too now that we added more test cases to QueryTrait::build() method which is used by both classes (AbstractActiveRecord and ActiveRelation). This way all those new test cases will be run against SQLite database too when running ./vendor/.bin/_ide_helper script on our project's root directory after installing dependencies with Composer using command composer install.

@codecov
Copy link

codecov bot commented Dec 28, 2022

Codecov Report

Base: 98.08% // Head: 98.08% // No change to project coverage 👍

Coverage data is based on head (4695638) compared to base (5430e16).
Patch has no changes to coverable lines.

❗ Current head 4695638 differs from pull request most recent head 35b913a. Consider uploading reports for the commit 35b913a to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #168   +/-   ##
=========================================
  Coverage     98.08%   98.08%           
  Complexity      326      326           
=========================================
  Files            17       17           
  Lines           990      990           
=========================================
  Hits            971      971           
  Misses           19       19           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@terabytesoftw terabytesoftw requested a review from darkdef January 2, 2023 12:24
@terabytesoftw terabytesoftw added the status:code review The pull request needs review. label Jan 2, 2023
@terabytesoftw terabytesoftw merged commit 38a5dda into master Jan 2, 2023
@terabytesoftw terabytesoftw deleted the add-more-tests branch January 2, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant