Skip to content

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

@what-the-diff
Copy link

what-the-diff bot commented Dec 30, 2022

  • Added Dsn class to support sqlite connection
  • Fixed phpdoc in ConnectionPDO::getSchema() method
  • Updated tests for new features and fixed some bugs there (see commit message)

@codecov
Copy link

codecov bot commented Dec 30, 2022

Codecov Report

Base: 98.05% // Head: 98.07% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (ca09e93) compared to base (e47c4cd).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #170      +/-   ##
============================================
+ Coverage     98.05%   98.07%   +0.01%     
- Complexity      322      324       +2     
============================================
  Files            16       17       +1     
  Lines           978      986       +8     
============================================
+ Hits            959      967       +8     
  Misses           19       19              
Impacted Files Coverage Δ
src/Dsn.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@terabytesoftw terabytesoftw marked this pull request as ready for review December 30, 2022 15:50
@terabytesoftw terabytesoftw added the status:code review The pull request needs review. label Dec 30, 2022
@terabytesoftw terabytesoftw merged commit 5430e16 into master Dec 30, 2022
@terabytesoftw terabytesoftw deleted the fix-phpdoc-more-test branch December 30, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants