Skip to content

Conversation

darkdef
Copy link
Contributor

@darkdef darkdef commented Jan 9, 2023

Q A
Is bugfix? ✔️
New feature? ✔️
Breaks BC? ✔️

@what-the-diff
Copy link

what-the-diff bot commented Jan 9, 2023

  • The profiler is now an interface.
  • A new method createProfiler() was added to the test class, which creates a mock of ProfilerInterface and returns it for use in tests.
  • In all places where DbHelper::getProfiler() used to be called, we are now calling $this->createProfile(). This allows us to have more control over what happens when profiling is enabled during testing (e.g., if we want our own implementation).

@darkdef darkdef merged commit d7c8553 into yiisoft:master Jan 9, 2023
@darkdef darkdef deleted the remove_profiler branch January 9, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants