Skip to content

Conversation

terabytesoftw
Copy link
Member

@terabytesoftw terabytesoftw commented Apr 3, 2023

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Issue yiisoft/db#634

@what-the-diff
Copy link

what-the-diff bot commented Apr 3, 2023

PR Summary

  • Changed method visibility
    Updated the visibility of the queryBuilder() method to protected
  • Renamed method
    Renamed the queryBuilder() method to getQueryBuilder() for better clarity

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (e819f42) 98.20% compared to head (2bc8a3a) 98.20%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #241   +/-   ##
=========================================
  Coverage     98.20%   98.20%           
  Complexity      329      329           
=========================================
  Files            17       17           
  Lines          1001     1001           
=========================================
  Hits            983      983           
  Misses           18       18           
Impacted Files Coverage Δ
src/CommandPDO.php 98.83% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@terabytesoftw terabytesoftw merged commit c8de2b1 into master Apr 3, 2023
@terabytesoftw terabytesoftw deleted the change-visibility-better-naming branch April 3, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants