-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix foreign keys #268
Fix foreign keys #268
Conversation
PR Summary
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #268 +/- ##
============================================
- Coverage 98.21% 98.02% -0.19%
- Complexity 325 328 +3
============================================
Files 17 17
Lines 1006 1013 +7
============================================
+ Hits 988 993 +5
- Misses 18 20 +2
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we mark TableSchema::compositeForeignKey()
as deprecated and remove it in the next major version?
Seems, TableSchemaInterface::compositeForeignKey()
used only here, and after merge of this PR can be marked as deprecated also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See previous comment and need line in changelog also.
And several optional suggestions.
# Conflicts: # src/Schema.php
null
columns for reference