Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate compositeForeignKey() #755

Merged
merged 4 commits into from
Sep 26, 2023

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Sep 23, 2023

See comment yiisoft/db-sqlite#268 (review)

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

@what-the-diff
Copy link

what-the-diff bot commented Sep 23, 2023

PR Summary

  • Deprecated compositeForeignKey() Method Noted
    A deprecation notice has been added to the method compositeForeignKey() in TableSchemaInterface.php. This indicates that we'll no longer support this method in the future.

  • Bug Fix in Quoter::quoteSql() Method
    An error found in the Quoter::quoteSql() method has been resolved. This bug was associated with SQL containing a table with a prefix.

  • Bug Fix in Quoter::getTableNameParts() Method
    A problem in the Quoter::getTableNameParts() method faced when different quotes for tables and columns are used has been fixed.

  • Bug Fix in Quoter::quoteTableName() Method
    A bug in the Quoter::quoteTableName() method dealing with sub-query with alias has been rectified.

  • Updated Change Log
    The change log has been updated to record the above-mentioned deprecation as well as the resolved bugs.

@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (264d589) 99.73% compared to head (dc799d2) 88.72%.

❗ Current head dc799d2 differs from pull request most recent head 1433c4c. Consider uploading reports for the commit 1433c4c to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             master     #755       +/-   ##
=============================================
- Coverage     99.73%   88.72%   -11.02%     
  Complexity     1268     1268               
=============================================
  Files            63       63               
  Lines          3045     3042        -3     
=============================================
- Hits           3037     2699      -338     
- Misses            8      343      +335     

see 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov marked this pull request as ready for review September 23, 2023 05:58
@Tigrov Tigrov requested a review from vjik September 25, 2023 10:58
@vjik
Copy link
Member

vjik commented Sep 25, 2023

I created issue #758

@Tigrov Add info about deprecated method to changelog, please.

CHANGELOG.md Outdated Show resolved Hide resolved
@vjik vjik merged commit a60a912 into yiisoft:master Sep 26, 2023
82 of 83 checks passed
@Tigrov Tigrov deleted the deprecate_compositeForeignKey branch September 26, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants