Skip to content
This repository was archived by the owner on Jun 11, 2021. It is now read-only.

Conversation

xepozz
Copy link
Member

@xepozz xepozz commented Jul 12, 2020

image

@xepozz xepozz requested a review from a team July 12, 2020 09:30
@mamadza
Copy link

mamadza commented Jul 12, 2020

Hi, I have question, what's the reason to use angular?
If angular version goes higher what's happen to incompatible

@xepozz
Copy link
Member Author

xepozz commented Jul 13, 2020

Hi, I have question, what's the reason to use angular?

After some private discussions I've realized that Angular will be more suitable for our frontend apps.

If angular version goes higher what's happen to incompatible

Incompatible for what?

@samdark
Copy link
Member

samdark commented Jul 14, 2020

Incompatible for what?

Incompatible with the application using another version of Angular. Because debug frontend consists of two parts:

  1. Viewer that is separate app. No problem here.
  2. Toolbar that is displayed at the bottom of application pages. This may be a problem.

"@angular/compiler": "~10.0.3",
"@angular/core": "~10.0.3",
"@angular/forms": "~10.0.3",
"@angular/http": "~7.2.16",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

@xepozz xepozz Jul 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anchor isn't found

@xepozz
Copy link
Member Author

xepozz commented Jul 15, 2020

Incompatible with the application using another version of Angular.

I get it.
Toolbar may be implemented as a extension to another JS frameworks (not only for Angular).
The viewer will separated standalone application, it won't used as a framework extension.

@samdark samdark merged commit 1e59190 into master Jul 15, 2020
@samdark
Copy link
Member

samdark commented Jul 15, 2020

OK. Let's start with this one.

@samdark samdark deleted the init branch July 15, 2020 10:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants