Skip to content

delete property maxPriority #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 14, 2023
Merged

delete property maxPriority #464

merged 4 commits into from
Jan 14, 2023

Conversation

skolkin-worker
Copy link
Contributor

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

So, it will be without backward compatibility.

@samdark samdark added the pr:missing usecase It is not clear what is the use case for the pull request. label Dec 27, 2022
@yii-bot
Copy link

yii-bot commented Dec 27, 2022

Thank you for putting effort in the improvement of the Yii framework.
We have reviewed your pull request.

Unfortunately a use case is missing. It is required to get a better understanding of the pull request and helps us to determine the necessity and applicability of the suggested change to the framework.

Could you supply us with a use case please? Please be as detailed as possible and show some code!

Thanks!

This is an automated comment, triggered by adding the label pr:missing usecase.

@skolkin-worker
Copy link
Contributor Author

Yes, of course. The created queue without the x argument is the x-max-priority and we start the queue listener.
We will get Error: PRECONDITION_FAILED - non-equivalent argument 'x-max-priority' for the queue 'queue' in vhost '/': the value '10' of type 'signedint' was received, but the current value is none.
And I want to be able to work with such a queue.

@samdark
Copy link
Member

samdark commented Dec 28, 2022

Isn't it better to configure the value for it?

@samdark samdark added status:under discussion and removed pr:missing usecase It is not clear what is the use case for the pull request. labels Dec 28, 2022
@skolkin-worker
Copy link
Contributor Author

The queue was created by another client. And I can't connect to it

@samdark
Copy link
Member

samdark commented Jan 7, 2023

Need some additional things:

  • UPGRADE
  • CHANGELOG

@skolkin-worker
Copy link
Contributor Author

Raise the major version?

@samdark
Copy link
Member

samdark commented Jan 9, 2023

Yes, I think so.

@samdark samdark merged commit 54d3512 into yiisoft:master Jan 14, 2023
@samdark
Copy link
Member

samdark commented Jan 14, 2023

Thanks.

@samdark samdark added this to the 3.0.0 milestone Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants