-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signing release packages and downloads #13204
Comments
Nice find! ;-) @cebe, you guys could also mention in contributing docs/readme that commits can be signed by the users as well. I personally would be happy to see the core developers signing their commits on permanent basis. Looks like a very nice feature! |
Warning about unsigned commit: https://github.com/andrewhowdencom/git-hooks/blob/master/post-commit Sign by default: https://github.com/andrewhowdencom/dotfiles/blob/master/.gitincludes#L7 |
What will happen with PR merge commit created at GitHub side by 'merge' button? |
It's not being signed. |
Also things you edit on github are not signed. |
Closing since releases are now signed. |
They kind of are, but we provide no information for people to verify that. Should be added. |
Moved to contrib repo. |
You might have seen Github showing singed commits: https://github.com/blog/2144-gpg-signature-verification
Imo we should apply this to the releases, i.e. sign the release tag and also the uploaded tar files.
PHP does this already: http://php.net/downloads.php#gpg-7.1
And eventually also composer would check these signatures: composer/composer#4022
Related resources:
The text was updated successfully, but these errors were encountered: