Skip to content

Conversation

arturf
Copy link
Contributor

@arturf arturf commented Nov 23, 2015

No description provided.

@samdark
Copy link
Member

samdark commented Nov 23, 2015

I'm not sure it's a good idea.

@samdark
Copy link
Member

samdark commented Nov 23, 2015

@yiisoft/core-developers opinions?

@klimov-paul
Copy link
Member

Method setAttributes() produces a virtual property attributes, so usually its return value is never used.
Still we can return a self reference as a result. However, there are many similar 'setters' around the framework. There should be a consistency among them.

@SilverFire
Copy link
Member

Agree with @klimov-paul

@samdark
Copy link
Member

samdark commented Nov 23, 2015

Since some setters return true/false depending on the result I don't think it's a good idea to return object instance for other cases.

@samdark samdark closed this Nov 23, 2015
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 645d818 on arturf:imp-models into ** on yiisoft:master**.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants