-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added postgresql features to reset seq/check integrity #1648
Conversation
tested it locally on database with several tables, works well, but to be sure can be tested by some other developers. Later maybe will provide tests (for now i am a little bit not known how to setup database for them in fw tests). |
related with #1646 |
fixed some bugs. ready for review. |
if ($table !== null && $table->sequenceName !== null) { | ||
$sequence='"'.$table->sequenceName.'"'; | ||
|
||
if(strpos($sequence,'.')!==false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix code style.
Looks good to me. Please fix the coding style pointed out by @samdark and also add a line to CHANGELOG. I will then merge it. Thanks! |
i also have small question, i've ported it from Yii1, so there was
and
to be true i dont remember when in postgresql schema can contain |
I'm not sure about For
|
ok, then will leave it for any case.
right, so maybe we need to make this:
or dont needed?
right, my misunderstanding. |
Sounds good to me. |
ok, so since `"ALTER TABLE "public"."tbl_user_profile" ENABLE TRIGGER ALL; "`` is valid in pgsql, will make changes according to the discussion and submit new push here. |
done, ready for review. |
added postgresql features to reset seq/check integrity
Thanks! |
Added some new features for postgresql. I also raised visibility of extremely useful method
findTablesNames
. Since it is different per database and user can not have one sql this method is very useful. I also enabled emulating prepare as i've described in comment.@qiangxue please review when you will have time