session regenerate race condition #1812
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you tested your changes? |
|
So I test it with running one more scripts by ajax, after this changes session regenated succesfully, |
|
Are you able to write to session after calling |
|
You're right, there was an error with the subsequent entry in the session, resolved by re-calling session_start. |
|
I "fixed" it by hiding the warning message. Because this issue is caused by race condition, I don't see a perfect solution to it. Could you test it to see if it works for you now? |
tonydspaniard
added a commit
to tonydspaniard/yii2
that referenced
this pull request
Feb 5, 2014
* upstream: (106 commits) fixed i18n link one more revert. Reverted changes unrelated to issue yiisoft#2325 Revert "fixing wrapping - my NetBeans has a mind of its own." Revert "deleting one space before `:`" deleting one space before `:` fixing wrapping - my NetBeans has a mind of its own. Adding support for the X-HTTP-Method-Override header. fixed test break. adjusted required packages for yii2-dev. Fixes yiisoft#1812: Hide potential warning message due to race condition occurring to `Session::regenerateID()` call docs fix fixed docs, added checks Fixed globalOptions array issue. removed suffix, since it will be applied later in getFixturesConfig method. method names fixed added docs added suffix added globalFixtures option Removed duplicated getAlias call. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
When two scripts simultaneously turning to session data, session id regeneration sometimes fails by "session_regenerate_id (): Session object destruction failed". This is a race condition. Maybe a recording session should be closed before regeneration?