[WIP] Bower package manager / non-PHP dependencies #3209

pmoust · 2014-04-21T17:39:50Z

jQuery is package is now fetched from Bower via bowerphp and loaded from bower_components directory. post-scripts are now in place to perform bower update/install after relevant composer command is issued.

Relates to yiisoft#2946 (comment)

pmoust · 2014-04-21T17:41:31Z

Re-submitted the PR due to forked repo branch being deleted in the past.

pmoust · 2014-04-21T19:24:24Z

Travis break has to do with Bee-Lab/bowerphp#36 I 'll submit a PR there if the maintainer is too busy.
(jquery-ui requires jquery>=1.6 in its bower.json, which currently bowerphp fails to interpret.

DrMabuse23 · 2014-04-21T20:02:45Z

nice

This reverts commit d58c2c6. Bowerphp resolved the issue with Github API pagination and added proper version tagging

pmoust · 2014-04-22T10:00:32Z

Should be fine now, maintainer fixed the pagination issue with Github API and has added proper release tags.

basil-inc · 2014-04-24T18:23:51Z

Thumbs up for adding bower support out-of-the-box!

samdark · 2014-04-24T18:37:40Z

pros

Provides a way to install/manage large variety of JS packages (Composer doesn't manage JS packages generally).
Allows Yii not to maintain own Composer JS packages.
Since it doesn't add any non-php dependencies it doesn't make framework entry level any higher.

cons

Two dependency configs insead of one. Complicates things a bit.

cebe · 2014-04-24T18:43:07Z

I am still thinking that this is something composer should implement as it is the case with pear packages for example.

What about the following situation:

I have a yii extension that requires jquery > 2.0. how would I define that and does dependency resolving work properly?

pmoust · 2014-04-24T18:57:32Z

@cebe does this cover your question http://stackoverflow.com/questions/16442012/bower-install-2-versions-of-jquery ?

cebe · 2014-04-24T19:01:24Z

that may be a workaround but in the first place I'd expect bower to complain about conflicting requirements when the app requires a different version that the extension.

Can you explain how I can add bower.json to an extension? When installing the extension, ist it enough to require it in composer.json or do I need more?

pmoust · 2014-04-24T19:02:40Z

Sorry, I misread your comment @cebe.
A yii extension requiring a specific version of jquery would define that version in its bower.json I suppose and be declared at a class extending AssetBundle. I don't see the problem here.

I would argue it is much better than packing the JS/CSS/Whatever within the yii extension itself.

cebe · 2014-04-24T19:04:38Z

I would argue it is much better than packing the JS/CSS/Whatever within the yii extension itself.

Don't get me wrong, I am for changing the current situation. But I am not sure if this solution really works. At least I did not fully understand the idea here and it looks to me there is something missing.

pmoust · 2014-04-24T19:20:38Z

There should not be a need to add it in composer.json, just bower.json, however if bowerphp is to be used from within composer like the hooks I have added to ease the curve as @samdark pointed out, then this extension might want to include such hooks as well. I am against it in general though.
An extension requiring a specific version would be best to declare the install directory within bower.json as illustrated on the StackOverflow link I pasted above, and link the assets to that one instead of overwriting others. For instance I would instruct a custom JUI-pmoust extension using jquery-ui vX.Y.Z to keep that package to @bower/jquery-ui-pmoust and keep that reference in the code itself.
Sorry if I am not making it very clear.

cebe · 2014-04-24T19:25:02Z

if my extension contains JS and PHP code, it has to be in composer.json as far as I see. Otherwise there would be no chance to autoload classes.
the problem here is that you can not run two versions of jquery on the same site without aliasing them. Also if the application requires the right version that is perfectly fine, I do not need an alternative version to be installed then. The case I am talking about is when versions are conflicting the package manager should warn about that and prevent installation.

As far as I see this problem can be solved better as a composer extension. Will try to check this option tomorrow. Thanks for your input so far!

DrMabuse23 · 2014-04-24T19:27:34Z

and how did you wann handle this ??

[scss]
@import
"bourbon",
"neat",
"neat-helpers",
"bitters/variables",
"bitters/typography",
"bitters/bitters",
"base",
"menu",
"logo",
"hover_tile",
"animate"
;

bourbon neat bitters are bower packages

pmoust · 2014-04-24T19:32:29Z

@cebe The yii extension will be added in composer.json of the project. The Bower assets of that extension are added to the bower.json of said extension, just like the PHP dependencies of said extension are added in the extension's composer.json.
I will get back to you with a definite answer about a version conflict if my previous answer does not cover you.

cebe · 2014-04-24T19:36:00Z

@brewing can you please elaborate a bit more about what problem you are describing?

DrMabuse23 · 2014-04-24T19:40:04Z

@cebe i mean how to handle scss files because '@bower ' still not exist in scss files.

cebe · 2014-04-24T19:42:21Z

'@bower ' still not exist in scss files.

what does that mean?

DrMabuse23 · 2014-04-24T19:44:25Z

the alias are not exist

For instance I would instruct a custom JUI-pmoust extension using jquery-ui vX.Y.Z to keep that package to @bower/jquery-ui-pmoust and keep that reference in the code itself.

DrMabuse23 · 2014-04-24T19:45:09Z

well for js files i think this will still work

qiangxue · 2014-04-24T19:48:57Z

@pmoust Assuming we take this PR and we are building an application which needs to use yii2-jui, what do we need to do in order to install and use yii2-jui?

pmoust · 2014-04-24T21:00:38Z

@qiangxue should be just adding yii2-jui into composer.json and installing it. I 'll mark this PR as [WIP] so I can integrate Bower support a tad better by the yii2-composer extension so there is a seamless integration with Bower without needing nodejs/npm/bower but just bowerphp to work.
It will be a global solution for all yii2-extensions. Directly using npm/bower will be strictly optional.

@cebe I am marking it WIP and will ping you to review when it is done.

qiangxue · 2014-04-24T21:29:31Z

Could you create a new PR which handlesyii2-composer and jquery only? Currently this PR about jui is too big to be easily reviewed.

tonydspaniard · 2014-04-28T14:11:20Z

Sorry to all, but even though I do believe is a good thing to have bower support, I have to admit (upon usage), that bower installations are not sync with composer installs and that causes our projects to be populated with folders such as:

bower_components
vendor (composer with some js installs)
components (some javascript packages install vendor refs on this folder instead in bower_components folder.

And tones of repetitive files (lots of scripts do have the js installed through composer). So, a developer has to be very careful not to end up with lots of repetitive scripts everywhere. BowerPHP is a great source, I used in some of my projects but a developer must be very, very careful. I don't think is good for a general purposes and it just suits certain scenarios.

kartik-v · 2014-05-02T06:50:33Z

Trying to look at the end design and pre-requisites to achieve that. Are we achieving somehow bower and composer to work together like this:

bower manages all JS and CSS packages and dependencies
composer manages all PHP dependencies.

Assuming above is true and all dependencies between PHP code and required JS/CSS work magically --- following is needed

We would also need to be kind of forcing a standard in building all extensions.

Extensions must use bower ONLY for maintaining all CSS & JS code.
Extensions must use composer ONLY for maintaining all PHP code.

If both are not adhered strictly - we may fall into issues. Am I right in framing this target design specification?

BTW - @pmoust great work so far.

creocoder · 2014-06-16T00:47:33Z

@pmoust Any news on it? Does that mean we will use famous bower instead of doubtful asset bundles approach? If so, than GREAT WORK! 👍

creocoder · 2014-06-16T00:53:16Z

Btw why bowerphp instead of original bower??? Vote against it.

samdark · 2014-06-16T06:17:41Z

@creocoder no, it's about getting JS/CSS files, not about serving or compressing these via asset bundles. Also phpbower allows you to use it right away while bower requires nodejs to be installed along with bower.

pmoust · 2014-06-16T08:01:57Z

@creocoder I 'll work on it during this weekend. I' ll choose whether closing this down in favor of a cleaner way to do things, or improve the current PR and request for review.

As @samdark mentioned, the only reason we go with bowerphp vs bower is to reduce the dependencies for developers and/or deploying mechanisms.

creocoder · 2014-06-16T11:09:32Z

@samdark @pmoust I thinks we need to go with original bower with possibility to switch to bowerphp as alternative. I do not see any relation from bowerphp to original bower creators. Also it have only 100 github stars. Trust bowerphp for now is BIG mistake.

samdark · 2014-06-16T11:11:47Z

@creocoder it will make Yii dependent on nodejs. We can't afford it.

creocoder · 2014-06-16T11:44:42Z

@samdark Then i vote against about bower at all. Or original bower, or composer (we can live with that). We can't trust bowerphp at all. This is not official bower.

DrMabuse23 · 2014-06-16T12:01:28Z

this make no sense to use bower over php !!!

samdark · 2014-06-16T12:06:08Z

The thing is that we cannot force requirement on nodejs, npm and bower since it will raise overall framework complexity significantly enough to lose very big part of the community.

samdark · 2014-06-16T13:44:57Z

Discussed a lot with @creocoder, got the following cons/pros and decided to leave everything as is + create a guide to using bower with Yii2 (not sure if it will be in official docs or Yii cookbook yet): https://docs.google.com/document/d/1PttOYSBHj6xuE4-iaOcUYLj0Ly5lLjANitNOZTaB2l8

pmoust added 12 commits April 2, 2014 19:10

Added Bower package manager support

419b94d

jQuery is package is now fetched from Bower via bowerphp and loaded from bower_components directory. post-scripts are now in place to perform bower update/install after relevant composer command is issued.

bower support - changelog bump

a60916f

added proper location of jquery asset

6d48bb4

added @bower alias, introduced bowerPath in configuration

5fdf257

added @bower alias info in docs

29a51a2

removed bowerPath from advanced template

280cbba

swapped erroneous path declaration

2ed1961

added jquery-ui dependency

d5f246c

pointed to @bower for jquery ui, and defaulted to "smoothness" css theme

94fbb10

removed unnecessary assets from jui

afef87f

Added support for jquery-ui / Yii2 jui

95c5089

Relates to yiisoft#2946 (comment)

Merge branch 'master' of https://github.com/yiisoft/yii2 into bowerphp

b839bbd

This was referenced Apr 21, 2014

Masked Input Upgrade #3196

Closed

missing support for >= operator in version Bee-Lab/bowerphp#36

Closed

dep. change

d58c2c6

cebe added this to the 2.0 RC milestone Apr 21, 2014

pmoust added 2 commits April 22, 2014 12:38

Revert "dep. change"

bd48a91

This reverts commit d58c2c6. Bowerphp resolved the issue with Github API pagination and added proper version tagging

Merge branch 'master' of https://github.com/yiisoft/yii2 into bowerphp

e5c7526

Added yiisoft#3209

92263d9

pmoust changed the title ~~Bower package manager / non-PHP dependencies~~ [WIP] Bower package manager / non-PHP dependencies Apr 24, 2014

cebe self-assigned this Jun 4, 2014

samdark added the status:under discussion label Jun 16, 2014

samdark closed this Jun 16, 2014

samdark mentioned this pull request Jun 16, 2014

How to use bower with Yii 2.0 samdark/yii2-cookbook#7

Closed

cebe mentioned this pull request Jun 29, 2014

Bower packages with BowerRepository composer/composer#3078

Closed

[WIP] Bower package manager / non-PHP dependencies #3209

[WIP] Bower package manager / non-PHP dependencies #3209

Conversation

pmoust commented Apr 21, 2014

pmoust commented Apr 21, 2014

pmoust commented Apr 21, 2014

DrMabuse23 commented Apr 21, 2014

pmoust commented Apr 22, 2014

basil-inc commented Apr 24, 2014

samdark commented Apr 24, 2014

cebe commented Apr 24, 2014

pmoust commented Apr 24, 2014

cebe commented Apr 24, 2014

pmoust commented Apr 24, 2014

cebe commented Apr 24, 2014

pmoust commented Apr 24, 2014

cebe commented Apr 24, 2014

DrMabuse23 commented Apr 24, 2014

pmoust commented Apr 24, 2014

cebe commented Apr 24, 2014

DrMabuse23 commented Apr 24, 2014

cebe commented Apr 24, 2014

DrMabuse23 commented Apr 24, 2014

DrMabuse23 commented Apr 24, 2014

qiangxue commented Apr 24, 2014

pmoust commented Apr 24, 2014

qiangxue commented Apr 24, 2014

tonydspaniard commented Apr 28, 2014

kartik-v commented May 2, 2014

creocoder commented Jun 16, 2014

creocoder commented Jun 16, 2014

samdark commented Jun 16, 2014

pmoust commented Jun 16, 2014

creocoder commented Jun 16, 2014

samdark commented Jun 16, 2014

creocoder commented Jun 16, 2014

DrMabuse23 commented Jun 16, 2014

samdark commented Jun 16, 2014

samdark commented Jun 16, 2014