Work around problem with braces messing up syntax highlighting #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported in yko#10, unclosed braces in templates can mess up the syntax highlighting of the following code. It seems the problem is with the `perlBraces` highlight region in `syntax/perl.vim` which uses the `extend` argument. This means Perl highlight region extends beyond the end of the template tag, messing the up the highlighting. Excluding the `perlBraces` seems to fix this problem. I'm not sure if there still are some cases where Perl code can cause the highlight region to be extended.
|
I found a much better fix: just exclude the Is there a way to tell Vim that we want to force |
|
Works well, thanks for this! |
This was referenced Aug 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #10, unclosed brackets in templates can mess up the syntax highlighting of the following code. It seems like the Perl highlight region does not end when the template tag ends. I have not identified the source of the issue but excluding the bracket from the Perl highlight region seems to fix the problem.
This patch does not fix cases where there's any non-whitespace characters after the bracket, e.g.
This works as a temporary band aid until the real issue is fixed.