Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add super linter Github Action #16

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Add super linter Github Action #16

wants to merge 11 commits into from

Conversation

antirotor
Copy link
Member

@antirotor antirotor commented May 21, 2024

This is adding Super Linter GH Action to the repo. Might not work at all for our use case.

It can be controlled with the set of env variables with supported launguages and linters.

How it is configured right now is that it should touch only files touched by the PR.

@antirotor antirotor changed the title Create super-linter.yml Add super linter Github Action May 21, 2024
Lypsolon and others added 7 commits May 28, 2024 16:30
* added AyonUsdLinux build script (script uses system installed python

* added option to define boost lib name appending

* added windows ayon usd build script

* added documentation for the build plugins (python part) added windows / linux to tested platforms

* added TestAyonUsd.bat

* added /changed AyonUsd build.bat and cmake

* made scrtips more readable based on BigRoy feedback

* added an ´ to an your

* added linux py310 maya 2024.2 build plugin. works for building resolver with 3 env variables. loads under Alma Linux9

* moved complie plugin include in order to allow for setting compiler in BuildPlugin

* t

* unreal is broken again

* conflickts

* build this new branch because its broken

* new version for ayon-cpp-api

* changed build scripts so that all off them can run without anny changes only the AyonUsd Cmake script needs to define the project first because off a variable deadlock. this version will probably not work under windowns because i did not update the windwos build scripts

* added windows build scripts for maya and unreal

* Unreal and Maya work for windows now

* changed maya naming to be py11

* this is the version off the code that produced the Resolvers for windows and linux from May15th2024

* updated AyonUsdWin AyonUsd23_5_py39 plugin because we neet to define project at the start off this plugin so that we dont get an infinit loop

* Update BuildPlugins/AyonUsdWin/AyonUsd23_5_py39.cmake

Co-authored-by: Ondřej Samohel <33513211+antirotor@users.noreply.github.com>

* Update BuildPlugins/MayaLinux/LinuxPy310Maya2024_2.cmake

Co-authored-by: Ondřej Samohel <33513211+antirotor@users.noreply.github.com>

* Update BuildPlugins/MayaLinux/LinuxPy311Maya2025.cmake

Co-authored-by: Ondřej Samohel <33513211+antirotor@users.noreply.github.com>

* Update BuildPlugins/MayaWin/WinPy310Maya2024_2.cmake

Co-authored-by: Ondřej Samohel <33513211+antirotor@users.noreply.github.com>

* Update README.md

Co-authored-by: Ondřej Samohel <33513211+antirotor@users.noreply.github.com>

* Update README.md

Co-authored-by: Ondřej Samohel <33513211+antirotor@users.noreply.github.com>

* Update README.md

Co-authored-by: Ondřej Samohel <33513211+antirotor@users.noreply.github.com>

* Update README.md

Co-authored-by: Ondřej Samohel <33513211+antirotor@users.noreply.github.com>

* Update README.md

Co-authored-by: Ondřej Samohel <33513211+antirotor@users.noreply.github.com>

* Update README.md

Co-authored-by: Ondřej Samohel <33513211+antirotor@users.noreply.github.com>

* Update README.md

Co-authored-by: Ondřej Samohel <33513211+antirotor@users.noreply.github.com>

* Update README.md

Co-authored-by: Ondřej Samohel <33513211+antirotor@users.noreply.github.com>

* Update README.md

Co-authored-by: Ondřej Samohel <33513211+antirotor@users.noreply.github.com>

* Update README.md

Co-authored-by: Ondřej Samohel <33513211+antirotor@users.noreply.github.com>

* Update README.md

Co-authored-by: Ondřej Samohel <33513211+antirotor@users.noreply.github.com>

* Update README.md

Co-authored-by: Ondřej Samohel <33513211+antirotor@users.noreply.github.com>

* removed one TODO tag because it was resoved

* updated ayon-cpp-api to develop branch because PythonBuildSetup branch was merged into it

* Update README.md

Co-authored-by: Ondřej Samohel <33513211+antirotor@users.noreply.github.com>

* Update README.md

Co-authored-by: Ondřej Samohel <33513211+antirotor@users.noreply.github.com>

---------

Co-authored-by: Lyon_Rosenblatt <48656065+lyon040502003@users.noreply.github.com>
Co-authored-by: Ondřej Samohel <33513211+antirotor@users.noreply.github.com>
Added Glossary of Terms and Conceptual framework as it became important for describing pinning support
Co-authored-by: Lyon_Rosenblatt <48656065+lyon040502003@users.noreply.github.com>
Co-authored-by: Ondřej Samohel <33513211+antirotor@users.noreply.github.com>
@antirotor antirotor self-assigned this Jul 9, 2024
@antirotor antirotor requested a review from a user July 9, 2024 08:18
@antirotor antirotor added the type: enhancement Enhancements to existing functionality label Jul 9, 2024
@BigRoy
Copy link
Collaborator

BigRoy commented Aug 28, 2024

This seems approved by Lyon, but still lingering for a while. Still relevant? If so, should we merge this?

@Lypsolon Lypsolon self-requested a review August 29, 2024 07:27
@Lypsolon
Copy link
Collaborator

lets not merge it right now.
sorry i removed my approve for now because right now its hard to find the time to do extensive testing.

i tryed implementing linting in some other Repo a short while back and it was havaly erroring.
over all i very much belie we should do linting but only with one linter super linter by default turns out to lint with multiple linters and they do disagree some time.

i vote for Black

@Lypsolon
Copy link
Collaborator

@antirotor if you want you can assign it to me and i do testing etc for linting in the next epic ?

or do you prefer having it before ?

Copy link
Collaborator

@Lypsolon Lypsolon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[duplicate because of GH]
lets limit this to one linter

Base automatically changed from develop to main September 13, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants