-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.2.1: enhance keyboard shortcut (word-break) #33
Conversation
I built this locally on an arm64 Mac and tested it inside default iTerm 2, Visual Studio Code's integrated terminal, and the native macOS Terminal. Installation/Compilation Notes
Test ResultsAs expected, default iTerm 2 still produces the same problem. For anyone who might stumble upon this, it's possible to alleviate this with the following configuration guide (the instructions are for an older version but the gist is the same). A nice treat, however, is that Visual Studio Code's integrated terminal seems to not be affected and works with this PR's changes out of the box. I suppose VS Code sends The default native macOS terminal works for |
@hu0p Thank you for pointing out the installation notes. I plan to address this in a separate PR.
Please try this with Option + D (without Shift), I also tested it on MacOS and it worked without any issues. |
Interesting. I'm unable to reproduce this. Option.+.D.mp4 |
Sounds good! Is your plan to update the docs to suggest the native approach or make the Dockerfile platform-independent? I'd be happy to give a shot, although I'm not sure what can be done about the homebrew on linux situation if that's a priority. Edit: looks like someone may have a related WiP open on this too https://github.com/ynqa/jnv/pull/32/files |
@hu0p Please check if the option is set to Esc+:
|
@hu0p This is about the topic of devcontainers, right? Initially, it was prepared for the verification of Homebrew for Linux, which I think would be beneficial to have in the future. However, I'm thinking now it was more important to complete a container environment in which jnv can be built properly, ignoring Homebrew. I would appreciate it if you could give it a try. (By the way, this is for a Dockerfile that builds, not for one that runs the binary, right? If it's the former, it's being discussed in #19) |
It wasn't. I had only set my configuration to send Esc+ on a key-combo level for those I mentioned. Sorry if that created confusion. If we're in agreement this kind of configuration is a reasonable pre-requisite for this functionality to work, I think this work is good to merge. After all, we can only offer keyboard shortcuts, not force TTYs to use them, right? 😁
Yep, I was referring to one that builds cross-platform. Thanks for pointing out #19. I'll take a stab at it and follow up with a PR or there if needed. |
@hu0p Yes, to my understanding, we cannot enforce it. Also, since the configuration depends on the editor (and possibly the keyboard), it would probably be difficult to accommodate all cases. As an example with text editors, it seems like there might be similar issues: Therefore, I will go ahead and merge this. Thank you very much for your cooperation in the review 🙇 Regarding #19, since there hasn't been any update from the person assigned, I think it's fine for you to go ahead and work on it freely. |
.
,|
,(
,)
,[
,]
).
,|
,(
,)
,[
,]
).
,|
,(
,)
,[
,]
).
,|
,(
,)
,[
,]
)Resolves #8