Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added LineSegment::distance_to_point #44

Merged
merged 3 commits into from
Feb 17, 2020
Merged

Conversation

zesterer
Copy link
Contributor

@zesterer zesterer commented Feb 6, 2020

Fairly self-explanatory.

Copy link
Owner

@yoanlcq yoanlcq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I've added some comments, mostly minor stuff, I'd like to be addressed before merging. :)

src/geom.rs Outdated Show resolved Hide resolved
src/geom.rs Show resolved Hide resolved
src/geom.rs Outdated Show resolved Hide resolved
src/geom.rs Show resolved Hide resolved
src/geom.rs Outdated Show resolved Hide resolved
@zesterer
Copy link
Contributor Author

zesterer commented Feb 9, 2020

Dammit. Just realised I accidentally ran cargo fmt. Let me reverse that.

@zesterer
Copy link
Contributor Author

@yoanlcq This is ready now

@yoanlcq
Copy link
Owner

yoanlcq commented Feb 17, 2020

I was about to ask "still no doc tests?" until I noticed the tests at the bottom. Looks good to me, let's merge!

I'll push a new version ASAP.

@yoanlcq yoanlcq merged commit c2c5886 into yoanlcq:master Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants