Re-export column_major matrix module from self #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh wow, this must have been be an unwanted side-effect of I suspect other modules might be affected, I'll take a look. Feel free to add yourself to the list of contributors in the meantime. |
|
OK, it appears this is the only place this issue occurs... Willing to merge when you're ready. :) |
|
Ye this should be the only occurence. Only encountered this by chance due to a type error when multiplying a matrix and a vector. 😄 |
|
Alright, let's merge; I'll publish the fix right away after bumping the version. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that
vek::mat::repr_simd::Mat3becomesrepr_cinstead due to an incorrect re-export definition.