Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document IP lookup feature / Fix iplookup None bug #160

Merged
merged 4 commits into from Oct 3, 2018
Merged

Document IP lookup feature / Fix iplookup None bug #160

merged 4 commits into from Oct 3, 2018

Conversation

slin63
Copy link
Contributor

@slin63 slin63 commented Oct 1, 2018

Short description of what this resolves:

Fixed yoda iplookup crashing when no argument was supplied.
Added README.md documentation as well as a link to the database used.

@slin63 slin63 mentioned this pull request Oct 1, 2018
2 tasks
@codecov-io
Copy link

codecov-io commented Oct 1, 2018

Codecov Report

Merging #160 into master will decrease coverage by 0.02%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #160      +/-   ##
==========================================
- Coverage   75.03%   75.01%   -0.03%     
==========================================
  Files          35       35              
  Lines        2359     2361       +2     
==========================================
+ Hits         1770     1771       +1     
- Misses        589      590       +1
Impacted Files Coverage Δ
modules/dev.py 78.44% <50%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5409930...4318bbe. Read the comment docs.

@slin63 slin63 changed the title proposed label: [hacktober] Document IP lookup feature / Fix iplookup None bug Document IP lookup feature / Fix iplookup None bug Oct 1, 2018
@manparvesh manparvesh merged commit 721b500 into yoda-pa:master Oct 3, 2018
@manparvesh manparvesh added this to the v1.0.0 milestone Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants