Add a component to build JobParameters defaults at contruction time #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J-Ben87
approved these changes
May 5, 2024
yann-eugone
force-pushed
the
job-parameters-defaults
branch
from
f05927b to
178bb32
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 0.x #123 +/- ##
=========================================
Coverage 99.71% 99.72%
- Complexity 890 906 +16
=========================================
Files 143 147 +4
Lines 2817 2879 +62
=========================================
+ Hits 2809 2871 +62
Misses 8 8 ☔ View full report in Codecov by Sentry. |
This was referenced Jan 8, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #93
\Yokai\Batch\Factory\JobExecutionParametersBuilderInterfacewas introduced to provide some parameters defaults, to be merged with those provided at runtimeIt is used in
\Yokai\Batch\Factory\JobExecutionFactorybefore constructing\Yokai\Batch\JobExecution