Skip to content

Conversation

yann-eugone
Copy link
Contributor

  • Centralize JobExecution id generation
  • Use service to generate JobExecution id

@codecov
Copy link

codecov bot commented Dec 18, 2020

Codecov Report

Merging #13 (04fbc6b) into 0.x (222d191) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                0.x      #13      +/-   ##
============================================
+ Coverage     82.29%   82.32%   +0.02%     
- Complexity      477      479       +2     
============================================
  Files            61       62       +1     
  Lines          1384     1386       +2     
============================================
+ Hits           1139     1141       +2     
  Misses          245      245              
Impacted Files Coverage Δ Complexity Δ
...atch-symfony-console/src/RunCommandJobLauncher.php 100.00% <ø> (ø) 2.00 <0.00> (ø)
...mfony-messenger/src/DispatchMessageJobLauncher.php 100.00% <ø> (ø) 2.00 <0.00> (ø)
src/batch/src/Factory/JobExecutionFactory.php 100.00% <100.00%> (ø) 2.00 <1.00> (+1.00)
...atch/src/Factory/UniqidJobExecutionIdGenerator.php 100.00% <100.00%> (ø) 1.00 <1.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 222d191...04fbc6b. Read the comment docs.

@yann-eugone yann-eugone merged commit e19c57f into 0.x Dec 18, 2020
yann-eugone added a commit that referenced this pull request Jan 11, 2021
* Centralize JobExecution default id generation

* Use service to generate JobExecution id
@yann-eugone yann-eugone deleted the job-execution-id-generation branch May 2, 2021 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant