Skip to content

Introduce a reader that read from a value fetched by a parameter accessor #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

yann-eugone
Copy link
Contributor

This reader will be useful to be combined with a writer that will be able to write to a job execution summary (#33)

@codecov
Copy link

codecov bot commented Sep 20, 2021

Codecov Report

Merging #34 (0667d09) into 0.x (c8f4e3f) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                0.x      #34      +/-   ##
============================================
+ Coverage     92.84%   92.87%   +0.02%     
- Complexity      620      623       +3     
============================================
  Files           100      101       +1     
  Lines          1789     1796       +7     
============================================
+ Hits           1661     1668       +7     
  Misses          128      128              
Impacted Files Coverage Δ
...ch/src/Job/Item/Reader/ParameterAccessorReader.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8f4e3f...0667d09. Read the comment docs.

@yann-eugone yann-eugone requested review from halundraN, Faulk13 and J-Ben87 and removed request for halundraN September 20, 2021 15:43
@yann-eugone yann-eugone merged commit f087e97 into 0.x Sep 22, 2021
@yann-eugone yann-eugone deleted the read-from-parameter-accessor branch September 27, 2021 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants