Skip to content

All jobs final once again, add decorator to help construction #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

yann-eugone
Copy link
Contributor

@yann-eugone yann-eugone commented Jun 8, 2023

Since #31, we allowed jobs to be extended
It was handy for Symfony project with PSR-4 service discovery.

But there is another way:

  • mark jobs as final once again
  • add an abstract decorator that helps construction

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (16983be) 99.95% compared to head (400ef68) 99.95%.

Additional details and impacted files
@@            Coverage Diff            @@
##                0.x      #82   +/-   ##
=========================================
  Coverage     99.95%   99.95%           
- Complexity      784      788    +4     
=========================================
  Files           133      134    +1     
  Lines          2148     2155    +7     
=========================================
+ Hits           2147     2154    +7     
  Misses            1        1           
Impacted Files Coverage Δ
src/batch/src/Job/Item/ItemJob.php 100.00% <ø> (ø)
src/batch/src/Job/JobWithChildJobs.php 100.00% <ø> (ø)
src/batch/src/Job/AbstractDecoratedJob.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yann-eugone yann-eugone merged commit 326afb4 into 0.x Jun 8, 2023
@yann-eugone yann-eugone deleted the decorated-job-and-final branch June 11, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant