Skip to content

Configurable enum #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 13, 2018
Merged

Configurable enum #27

merged 6 commits into from
Feb 13, 2018

Conversation

yann-eugone
Copy link
Collaborator

@yann-eugone yann-eugone commented Jan 16, 2018

see #24

  • Add the 2 configurable enum classes to the source code
  • Add testing for those two classes
  • Add more documentation about usage and examples
  • Add enum autoconfiguration within the bundle extension

@yann-eugone
Copy link
Collaborator Author

yann-eugone commented Feb 12, 2018

@J-Ben87
Copy link
Contributor

J-Ben87 commented Feb 12, 2018

I like it! You allowed the different solution in a non intrusive way, I can't think of a better solution.

@yann-eugone
Copy link
Collaborator Author

What about the documentation ? Do you think it is clear enough ?

@J-Ben87
Copy link
Contributor

J-Ben87 commented Feb 13, 2018

I think so. Maybe because I already know how to use it, but it seems pretty clear. You detailed all the ways to declare enums, how to integrate it with Sonata...
Maybe you could add a little note on how to use it in forms without type guessing, or on how to use the translated enum.

@yann-eugone
Copy link
Collaborator Author

Just added more documentation, and fixed some important inconsistent issues with namespaces (from symfony 3 to symfony 4 conventions)

@yann-eugone yann-eugone merged commit 2ce47e1 into master Feb 13, 2018
@yann-eugone yann-eugone deleted the configurable-enum branch February 13, 2018 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants