Improved concordance method #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separated in different functions for getting term positions and extracting the desired context. Also added the option to mark the term.
Changed negated set to negative lookahead and lookbehind. This way it will capture correctly groups at the beginning of the string and at the end of the string without the need to add spaces.
Assigned a temp variable for the converted corpus text (ISO-8859-1) instead of changing the attribute. It will prevent to convert an already converted corpus text.
Added parameter tags to the methods markString and getExcerpt.
Separated from concordance method the code block that finds the needle positions and the code block that extract an excerpt of the text. Also included option to mark the needle to the returned text.
Removed extractExcerptTerm method that was not used anymore.
|
Thanks, I will check it out this week and get back to you. |
|
Thanks for the contribution |
|
Nice @yooper 🐺 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, @yooper !
@thiagogomesverissimo and I worked some things on the concordance method.
end of the string without the need to add spaces.
If you have any questions or suggestions, feel free to ask me or @thiagogomesverissimo .
Thank you.