Fixed polarity bug getting 'Undefined offset: 1' along with normalization bug getting Divison by zero error. #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 30, 2020 20:59
… word 'of' after 'kind' where kind is the last word in the sentence
hartmann-lars
changed the title
hartmann-lars
changed the title
|
Thank you for the contributions! |
|
Thank you too for sharing your great work. Best solution out there for PHP 2020 IMO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking for the word 'of' after 'kind' where 'kind' is the last word in the sentence it will cause a lookup at an not existing index in the array.
Also fixing normalize divison by zero issue. The following trump tweet was tokenized in the unit test as it resolves to zero.