Added support for wamania/php-stemmer ^2 and ^3 #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the contribution, I will run the tests to verify compability and merge in the next couple days, if it all works. |
|
I merged your change in. It did require code changes. Luckily it did not require much re-work. |
|
Ah sorry, missed the dynamic buildup of the namespace, nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it looks like
warmania/php-stemmeris only used here. Adding support forv2andv3shouldn't be of high impact.Also don't see any major changes from current support
v1vsv3(diff).Adding the support for newer versions makes the library a bit more flexible/usable :)