Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIM Preflight check test for IFCv4 support fails quietly on python >= 3.9 #134

Closed
mrevl opened this issue Feb 15, 2024 · 1 comment
Closed

Comments

@mrevl
Copy link

mrevl commented Feb 15, 2024

In https://github.com/yorikvanhavre/BIM_Workbench/blob/master/BimPreflight.py
Context:
from packaging import version
cur_version = version.parse(ifcopenshell.version)
if type(cur_version) == version.LegacyVersion:

However as per python 3.9 LegacyVersion got removed, which then quietly causes
except Exception as e:
self.failed(test)

to get thrown.

Ideas:
-remove the check on LegacyVersion
-test for python <3.9

In this case it looks like a workaround for a problem that wasn't supposed to exist in the first place, haven't looked into this too deeply yet.

For more info see
pypa/packaging#530

@yorikvanhavre
Copy link
Owner

Hopefully fixed now! Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants