4.05 typing fix #20
Merged
4.05 typing fix #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 4.05, checking for non-generalizable inference variable ('_a)
(forbidden in toplevel modules and functors) happens before checking
the .ml file against the .mli signature, so non-generalizable
variables that were previously resolved through the .mli constraint
are now underspecified and result in a compilation failure
(see MPR#7414, GPR#929). This commit adds enough annotations to avoid
such underspecified variables in functors.
Closed
gasche
added a commit
to gasche/opam-repository
that referenced
this pull request
Mar 12, 2017
…ml 4.05.0 The patch is taken from the upstream repository https://github.com/yoriyuki/Camomile/commit/0fa0a19f15998e89e4b04150dd74529bbd406f42.patch (I had to remove all "Camomile/" occurrences to adapt to the release-packaging filesystem organization) This should be the only change required to get Camomile working under 4.05.0, even though Camomile testing revealed a few regressions in the 4.05.0+beta2 -- the patch in itself does not suffice to compile Camomile on 4.05.0+beta2, but the remaining issues will be fixed upstream before the release. More context: yoriyuki/Camomile#21 yoriyuki/Camomile#20 See the upstream 4.05.0 compatibility discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 4.05, checking for non-generalizable inference variable (
'_a)(forbidden in toplevel modules and functors) happens before checking
the .ml file against the .mli signature, so non-generalizable
variables that were previously resolved through the .mli constraint
are now underspecified and result in a compilation failure
(see MPR#7414, GPR#929). This commit adds enough annotations to avoid
such underspecified variables in functors.