You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've created a complete Simplified Chinese (简体中文) localization for superfile, including all TUI strings, CLI help text, config file comments, hotkey descriptions, and error messages.
During the localization work, I also found and fixed a rendering bug related to CJK wide characters.
superfile as the application brand name is kept in English, as it is a proper noun.
Bug fix: CJK wide character rendering
When CJK characters (e.g. Chinese) are used in border titles or bottom info items, lipgloss v2 counts runes instead of display width when computing vertical padding. This causes the rendered output to be one line short, resulting in missing bottom borders.
I fixed this in src/internal/ui/rendering/renderer_core.go by pre-padding content to the expected height before passing it to lipgloss, so lipgloss doesn't need to add its own (incorrect) padding. This fix is independent of the localization and could be submitted as a separate PR.
All existing tests pass with these changes.
Question
I'd like to know the maintainer's preference before submitting a PR:
Would you accept a Chinese localization PR? If yes, would you prefer:
Option A: Directly replace English strings with Chinese (current approach)
Option B: Introduce an i18n framework to support multiple languages with runtime switching
Can I submit the CJK rendering fix as a separate PR? This is a general bug that affects any language using wide characters, not just Chinese.
I'm happy to adjust my approach based on your feedback. Screenshots of the localized interface are attached below.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Background
I've created a complete Simplified Chinese (简体中文) localization for superfile, including all TUI strings, CLI help text, config file comments, hotkey descriptions, and error messages.
During the localization work, I also found and fixed a rendering bug related to CJK wide characters.
What was localized
--helpoutput,path-listlabels, flag descriptions, update notificationsconfig.tomlandhotkeys.tomlsuperfileas the application brand name is kept in English, as it is a proper noun.Bug fix: CJK wide character rendering
When CJK characters (e.g. Chinese) are used in border titles or bottom info items, lipgloss v2 counts runes instead of display width when computing vertical padding. This causes the rendered output to be one line short, resulting in missing bottom borders.
I fixed this in
src/internal/ui/rendering/renderer_core.goby pre-padding content to the expected height before passing it to lipgloss, so lipgloss doesn't need to add its own (incorrect) padding. This fix is independent of the localization and could be submitted as a separate PR.All existing tests pass with these changes.
Question
I'd like to know the maintainer's preference before submitting a PR:
Would you accept a Chinese localization PR? If yes, would you prefer:
Can I submit the CJK rendering fix as a separate PR? This is a general bug that affects any language using wide characters, not just Chinese.
I'm happy to adjust my approach based on your feedback. Screenshots of the localized interface are attached below.
All reactions