fix: PhpDoc blocks and options constants #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
webarchitect609
commented
Dec 17, 2020
webarchitect609
commented
- Fixed: not all nessesary '@throws' specified
- All phpDoc blocks pulled up from Backoff to BackoffInterface and '@inheritdoc' is used instead
- Refactoring: all options are moved to constants of BackoffInterface so nobody can ever misspell any option
- Fixed: typo in method name Backoff::maxAttempsExceeded()
- Fixed: not all nessesary '@throws' specified - All phpDoc blocks pulled up from Backoff to BackoffInterface and '@inheritdoc' is used instead - Refactoring: all options are moved to constants of BackoffInterface so nobody can ever misspell any option - Fixed: typo in method name Backoff::maxAttempsExceeded()
|
"Some checks haven’t completed yet" - because you have to switch to travis-ci.com , then got 10K free credits and run the build. Then maybe apply for free OpenSource credits. Meanwhile you can see build result in my repo's Travis report here |
|
Thanks for the contribution, I'm glad you found the library useful. close #13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.