Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that --audio-quality is used when converting #3117

Closed
wants to merge 1 commit into from

Conversation

revolter
Copy link
Contributor

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

I thought that my change makes it clearer that --audio-quality is only used when converting the file, as stated here: https://discord.com/channels/807245652072857610/807247901981016094/954720168184008754.

If not, feel free to close this.

@pukkandan pukkandan added the docs/meta/cleanup related to docs, code cleanup, templates, devscripts etc label Mar 19, 2022
@pukkandan pukkandan closed this in a44ca5a Apr 5, 2022
@revolter revolter deleted the patch-1 branch April 5, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs/meta/cleanup related to docs, code cleanup, templates, devscripts etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants