-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[misc] Cleanup for 2024-05 release #9765
Conversation
Authored by: bashonly
Authored by: bashonly
…3.13) Authored by: bashonly
Authored by: bashonly
Authored by: bashonly
@@ -108,7 +108,6 @@ File|Description | |||
[yt-dlp_x86.exe](https://github.com/yt-dlp/yt-dlp/releases/latest/download/yt-dlp_x86.exe)|Windows (Win7 SP1+) standalone x86 (32-bit) binary | |||
[yt-dlp_min.exe](https://github.com/yt-dlp/yt-dlp/releases/latest/download/yt-dlp_min.exe)|Windows (Win7 SP1+) standalone x64 binary built with `py2exe`<br/> ([Not recommended](#standalone-py2exe-builds-windows)) | |||
[yt-dlp_linux](https://github.com/yt-dlp/yt-dlp/releases/latest/download/yt-dlp_linux)|Linux standalone x64 binary | |||
[yt-dlp_linux.zip](https://github.com/yt-dlp/yt-dlp/releases/latest/download/yt-dlp_linux.zip)|Unpackaged Linux executable (no auto-update) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we dropping it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mamba build suddenly didnt want to work anymore and so we had to switch to a different strategy (statically linked musl libc builds). I have a plan to potentially bring them back but it will require some research and some trial and error. Bringing back working builds seemed of more immediate importance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have seen the discussion. But the zip build will be the same workflow with pyinstaller --one-dir
, no? Sure, fixing it is not a priority, but I thought it'd be trivial
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is a good overview of what staticx does: JonathonReinhart/staticx#239 (comment)
It works similarly to pyinstaller --onefile
; it's just another layer of bundling on top with some RPATH
+INTERP
special sauce. The maintainer also says here that it's not possible to use staticx with pyinstaller --onedir
builds, so we would need to get very inventive to prove them wrong(?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On that note, I think the static exe is a bit problematic since we are doubling the startup time and /tmp usage. I want to try replacing the linux_arm
job with a CentOS 7 build flow; if that's successful, and if we can't find a way to optimize the static exe, then maybe we could build the linux_exe
using the CentOS 7 framework as well.
And exclude custom formats that would require custom live downloaders
Authored by: bashonly
Authored by: bashonly
Authored by: bashonly
Authored by: bashonly
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
Fixes #9763
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?