BUG: fix a bug where automatically computed symlog linear threshold would sometimes cause a crash in matplotlib #3859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
force-pushed
the
hotfix_symlog
branch
from
8d9b712
to
e80fbdd
Compare
…ould sometimes cause a crash in matplotlib
neutrinoceros
force-pushed
the
hotfix_symlog
branch
from
e80fbdd
to
1ee710a
Compare
neutrinoceros
changed the title
neutrinoceros
changed the title
|
Yup, got two versions of the same image plot (one in cylindrical and the other in spherical geometry) showing a diff, which is absolutely expected. Now waiting for a pre-approval before I can bump the reference images |
|
Thanks! I'll try it out once it's merged into main. |
chrishavlin
previously approved these changes
Mar 28, 2022
chrishavlin
approved these changes
Mar 30, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/yt
that referenced
this pull request
Mar 30, 2022
…ted symlog linear threshold would sometimes cause a crash in matplotlib
neutrinoceros
added a commit
that referenced
this pull request
Mar 30, 2022
…9-on-yt-4.0.x Backport PR #3859 on branch yt-4.0.x (BUG: fix a bug where automatically computed symlog linear threshold would sometimes cause a crash in matplotlib)
This was referenced Apr 5, 2022
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
fix #3858
This solution is directly extracted from my work in #3849, which is much too big for backporting.
Because this changes the rules for how automatic symlog thresholds are computed, I expect that some image tests could need an update.